#ifndef _NET_DN_FIB_H #define _NET_DN_FIB_H #include extern const struct nla_policy rtm_dn_policy[]; struct dn_fib_res { struct fib_rule *r; struct dn_fib_info *fi; unsigned char prefixlen; unsigned char nh_sel; unsigned char type; unsigned char scope; }; struct dn_fib_nh { struct net_device *nh_dev; unsigned int nh_flags; unsigned char nh_scope; int nh_weight; int nh_power; int nh_oif; __le16 nh_gw; }; struct dn_fib_info { struct dn_fib_info *fib_next; struct dn_fib_info *fib_prev; int fib_treeref; atomic_t fib_clntref; int fib_dead; unsigned int fib_flags; int fib_protocol; __le16 fib_prefsrc; __u32 fib_priority; __u32 fib_metrics[RTAX_MAX]; int fib_nhs; int fib_power; struct dn_fib_nh fib_nh[0]; #define dn_fib_dev fib_nh[0].nh_dev }; #define DN_FIB_RES_RESET(res) ((res).nh_sel = 0) #define DN_FIB_RES_NH(res) ((res).fi->fib_nh[(res).nh_sel]) #define DN_FIB_RES_PREFSRC(res) ((res).fi->fib_prefsrc ? : __dn_fib_res_prefsrc(&res)) #define DN_FIB_RES_GW(res) (DN_FIB_RES_NH(res).nh_gw) #define DN_FIB_RES_DEV(res) (DN_FIB_RES_NH(res).nh_dev) #define DN_FIB_RES_OIF(res) (DN_FIB_RES_NH(res).nh_oif) typedef struct { __le16 datum; } dn_fib_key_t; typedef struct { __le16 datum; } dn_fib_hash_t; typedef struct { __u16 datum; } dn_fib_idx_t; struct dn_fib_node { struct dn_fib_node *fn_next; struct dn_fib_info *fn_info; #define DN_FIB_INFO(f) ((f)->fn_info) dn_fib_key_t fn_key; u8 fn_type; u8 fn_scope; u8 fn_state; }; struct dn_fib_table { struct hlist_node hlist; u32 n; int (*insert)(struct dn_fib_table *t, struct rtmsg *r, struct nlattr *attrs[], struct nlmsghdr *n, struct netlink_skb_parms *req); int (*delete)(struct dn_fib_table *t, struct rtmsg *r, struct nlattr *attrs[], struct nlmsghdr *n, struct netlink_skb_parms *req); int (*lookup)(struct dn_fib_table *t, const struct flowidn *fld, struct dn_fib_res *res); int (*flush)(struct dn_fib_table *t); int (*dump)(struct dn_fib_table *t, struct sk_buff *skb, struct netlink_callback *cb); unsigned char data[0]; }; #ifdef CONFIG_DECNET_ROUTER /* * dn_fib.c */ void dn_fib_init(void); void dn_fib_cleanup(void); int dn_fib_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg); struct dn_fib_info *dn_fib_create_info(const struct rtmsg *r, struct nlattr *attrs[], const struct nlmsghdr *nlh, int *errp); int dn_fib_semantic_match(int type, struct dn_fib_info *fi, const struct flowidn *fld, struct dn_fib_res *res); void dn_fib_release_info(struct dn_fib_info *fi); void dn_fib_flush(void); void dn_fib_select_multipath(const struct flowidn *fld, struct dn_fib_res *res); /* * dn_tables.c */ struct dn_fib_table *dn_fib_get_table(u32 n, int creat); struct dn_fib_table *dn_fib_empty_table(void); void dn_fib_table_init(void); void dn_fib_table_cleanup(void); /* * dn_rules.c */ void dn_fib_rules_init(void); void dn_fib_rules_cleanup(void); unsigned int dnet_addr_type(__le16 addr); int dn_fib_lookup(struct flowidn *fld, struct dn_fib_res *res); int dn_fib_dump(struct sk_buff *skb, struct netlink_callback *cb); void dn_fib_free_info(struct dn_fib_info *fi); static inline void dn_fib_info_put(struct dn_fib_info *fi) { if (atomic_dec_and_test(&fi->fib_clntref)) dn_fib_free_info(fi); } static inline void dn_fib_res_put(struct dn_fib_res *res) { if (res->fi) dn_fib_info_put(res->fi); if (res->r) fib_rule_put(res->r); } #else /* Endnode */ #define dn_fib_init() do { } while(0) #define dn_fib_cleanup() do { } while(0) #define dn_fib_lookup(fl, res) (-ESRCH) #define dn_fib_info_put(fi) do { } while(0) #define dn_fib_select_multipath(fl, res) do { } while(0) #define dn_fib_rules_policy(saddr,res,flags) (0) #define dn_fib_res_put(res) do { } while(0) #endif /* CONFIG_DECNET_ROUTER */ static inline __le16 dnet_make_mask(int n) { if (n) return cpu_to_le16(~((1 << (16 - n)) - 1)); return cpu_to_le16(0); } #endif /* _NET_DN_FIB_H */ ption value='0' selected='selected'>unified
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /net/mpls
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/mpls')