#ifndef _NET_GARP_H #define _NET_GARP_H #include #define GARP_PROTOCOL_ID 0x1 #define GARP_END_MARK 0x0 struct garp_pdu_hdr { __be16 protocol; }; struct garp_msg_hdr { u8 attrtype; }; enum garp_attr_event { GARP_LEAVE_ALL, GARP_JOIN_EMPTY, GARP_JOIN_IN, GARP_LEAVE_EMPTY, GARP_LEAVE_IN, GARP_EMPTY, }; struct garp_attr_hdr { u8 len; u8 event; u8 data[]; }; struct garp_skb_cb { u8 cur_type; }; static inline struct garp_skb_cb *garp_cb(struct sk_buff *skb) { BUILD_BUG_ON(sizeof(struct garp_skb_cb) > FIELD_SIZEOF(struct sk_buff, cb)); return (struct garp_skb_cb *)skb->cb; } enum garp_applicant_state { GARP_APPLICANT_INVALID, GARP_APPLICANT_VA, GARP_APPLICANT_AA, GARP_APPLICANT_QA, GARP_APPLICANT_LA, GARP_APPLICANT_VP, GARP_APPLICANT_AP, GARP_APPLICANT_QP, GARP_APPLICANT_VO, GARP_APPLICANT_AO, GARP_APPLICANT_QO, __GARP_APPLICANT_MAX }; #define GARP_APPLICANT_MAX (__GARP_APPLICANT_MAX - 1) enum garp_event { GARP_EVENT_REQ_JOIN, GARP_EVENT_REQ_LEAVE, GARP_EVENT_R_JOIN_IN, GARP_EVENT_R_JOIN_EMPTY, GARP_EVENT_R_EMPTY, GARP_EVENT_R_LEAVE_IN, GARP_EVENT_R_LEAVE_EMPTY, GARP_EVENT_TRANSMIT_PDU, __GARP_EVENT_MAX }; #define GARP_EVENT_MAX (__GARP_EVENT_MAX - 1) enum garp_action { GARP_ACTION_NONE, GARP_ACTION_S_JOIN_IN, GARP_ACTION_S_LEAVE_EMPTY, }; struct garp_attr { struct rb_node node; enum garp_applicant_state state; u8 type; u8 dlen; unsigned char data[]; }; enum garp_applications { GARP_APPLICATION_GVRP, __GARP_APPLICATION_MAX }; #define GARP_APPLICATION_MAX (__GARP_APPLICATION_MAX - 1) struct garp_application { enum garp_applications type; unsigned int maxattr; struct stp_proto proto; }; struct garp_applicant { struct garp_application *app; struct net_device *dev; struct timer_list join_timer; spinlock_t lock; struct sk_buff_head queue; struct sk_buff *pdu; struct rb_root gid; struct rcu_head rcu; }; struct garp_port { struct garp_applicant __rcu *applicants[GARP_APPLICATION_MAX + 1]; struct rcu_head rcu; }; int garp_register_application(struct garp_application *app); void garp_unregister_application(struct garp_application *app); int garp_init_applicant(struct net_device *dev, struct garp_application *app); void garp_uninit_applicant(struct net_device *dev, struct garp_application *app); int garp_request_join(const struct net_device *dev, const struct garp_application *app, const void *data, u8 len, u8 type); void garp_request_leave(const struct net_device *dev, const struct garp_application *app, const void *data, u8 len, u8 type); #endif /* _NET_GARP_H */ elect name='qt'>
path: root/tools/thermal/tmon/Makefile
diff options
context:
space:
mode:
authorDouglas Miller <dougmill@linux.vnet.ibm.com>2017-01-28 06:42:20 -0600
committerTejun Heo <tj@kernel.org>2017-01-28 07:49:42 -0500
commit966d2b04e070bc040319aaebfec09e0144dc3341 (patch)
tree4b96156e3d1dd4dfd6039b7c219c9dc4616da52d /tools/thermal/tmon/Makefile
parent1b1bc42c1692e9b62756323c675a44cb1a1f9dbd (diff)
percpu-refcount: fix reference leak during percpu-atomic transition
percpu_ref_tryget() and percpu_ref_tryget_live() should return "true" IFF they acquire a reference. But the return value from atomic_long_inc_not_zero() is a long and may have high bits set, e.g. PERCPU_COUNT_BIAS, and the return value of the tryget routines is bool so the reference may actually be acquired but the routines return "false" which results in a reference leak since the caller assumes it does not need to do a corresponding percpu_ref_put(). This was seen when performing CPU hotplug during I/O, as hangs in blk_mq_freeze_queue_wait where percpu_ref_kill (blk_mq_freeze_queue_start) raced with percpu_ref_tryget (blk_mq_timeout_work). Sample stack trace: __switch_to+0x2c0/0x450 __schedule+0x2f8/0x970 schedule+0x48/0xc0 blk_mq_freeze_queue_wait+0x94/0x120 blk_mq_queue_reinit_work+0xb8/0x180 blk_mq_queue_reinit_prepare+0x84/0xa0 cpuhp_invoke_callback+0x17c/0x600 cpuhp_up_callbacks+0x58/0x150 _cpu_up+0xf0/0x1c0 do_cpu_up+0x120/0x150 cpu_subsys_online+0x64/0xe0 device_online+0xb4/0x120 online_store+0xb4/0xc0 dev_attr_store+0x68/0xa0 sysfs_kf_write+0x80/0xb0 kernfs_fop_write+0x17c/0x250 __vfs_write+0x6c/0x1e0 vfs_write+0xd0/0x270 SyS_write+0x6c/0x110 system_call+0x38/0xe0 Examination of the queue showed a single reference (no PERCPU_COUNT_BIAS, and __PERCPU_REF_DEAD, __PERCPU_REF_ATOMIC set) and no requests. However, conditions at the time of the race are count of PERCPU_COUNT_BIAS + 0 and __PERCPU_REF_DEAD and __PERCPU_REF_ATOMIC set. The fix is to make the tryget routines use an actual boolean internally instead of the atomic long result truncated to a int. Fixes: e625305b3907 percpu-refcount: make percpu_ref based on longs instead of ints Link: https://bugzilla.kernel.org/show_bug.cgi?id=190751 Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com> Reviewed-by: Jens Axboe <axboe@fb.com> Signed-off-by: Tejun Heo <tj@kernel.org> Fixes: e625305b3907 ("percpu-refcount: make percpu_ref based on longs instead of ints") Cc: stable@vger.kernel.org # v3.18+
Diffstat (limited to 'tools/thermal/tmon/Makefile')