/********************************************************************* * * Filename: iriap_event.h * Version: * Description: * Status: Experimental. * Author: Dag Brattli * Created at: Mon Aug 4 20:40:53 1997 * Modified at: Sun Oct 31 22:02:54 1999 * Modified by: Dag Brattli * * Copyright (c) 1998-1999 Dag Brattli , All Rights Reserved. * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License as * published by the Free Software Foundation; either version 2 of * the License, or (at your option) any later version. * * Neither Dag Brattli nor University of Tromsø admit liability nor * provide warranty for any of this software. This material is * provided "AS-IS" and at no charge. * ********************************************************************/ #ifndef IRIAP_FSM_H #define IRIAP_FSM_H /* Forward because of circular include dependecies */ struct iriap_cb; /* IrIAP states */ typedef enum { /* Client */ S_DISCONNECT, S_CONNECTING, S_CALL, /* S-Call */ S_MAKE_CALL, S_CALLING, S_OUTSTANDING, S_REPLYING, S_WAIT_FOR_CALL, S_WAIT_ACTIVE, /* Server */ R_DISCONNECT, R_CALL, /* R-Connect */ R_WAITING, R_WAIT_ACTIVE, R_RECEIVING, R_EXECUTE, R_RETURNING, } IRIAP_STATE; typedef enum { IAP_CALL_REQUEST, IAP_CALL_REQUEST_GVBC, IAP_CALL_RESPONSE, IAP_RECV_F_LST, IAP_LM_DISCONNECT_INDICATION, IAP_LM_CONNECT_INDICATION, IAP_LM_CONNECT_CONFIRM, } IRIAP_EVENT; void iriap_next_client_state (struct iriap_cb *self, IRIAP_STATE state); void iriap_next_call_state (struct iriap_cb *self, IRIAP_STATE state); void iriap_next_server_state (struct iriap_cb *self, IRIAP_STATE state); void iriap_next_r_connect_state(struct iriap_cb *self, IRIAP_STATE state); void iriap_do_client_event(struct iriap_cb *self, IRIAP_EVENT event, struct sk_buff *skb); void iriap_do_call_event (struct iriap_cb *self, IRIAP_EVENT event, struct sk_buff *skb); void iriap_do_server_event (struct iriap_cb *self, IRIAP_EVENT event, struct sk_buff *skb); void iriap_do_r_connect_event(struct iriap_cb *self, IRIAP_EVENT event, struct sk_buff *skb); #endif /* IRIAP_FSM_H */ /cgit.cgi/linux/net-next.git/log/tools/testing/selftests/firmware/fw_filesystem.sh'>
diff options
context:
space:
mode:
authorDouglas Miller <dougmill@linux.vnet.ibm.com>2017-01-28 06:42:20 -0600
committerTejun Heo <tj@kernel.org>2017-01-28 07:49:42 -0500
commit966d2b04e070bc040319aaebfec09e0144dc3341 (patch)
tree4b96156e3d1dd4dfd6039b7c219c9dc4616da52d /tools/testing/selftests/firmware/fw_filesystem.sh
parent1b1bc42c1692e9b62756323c675a44cb1a1f9dbd (diff)
percpu-refcount: fix reference leak during percpu-atomic transition
percpu_ref_tryget() and percpu_ref_tryget_live() should return "true" IFF they acquire a reference. But the return value from atomic_long_inc_not_zero() is a long and may have high bits set, e.g. PERCPU_COUNT_BIAS, and the return value of the tryget routines is bool so the reference may actually be acquired but the routines return "false" which results in a reference leak since the caller assumes it does not need to do a corresponding percpu_ref_put(). This was seen when performing CPU hotplug during I/O, as hangs in blk_mq_freeze_queue_wait where percpu_ref_kill (blk_mq_freeze_queue_start) raced with percpu_ref_tryget (blk_mq_timeout_work). Sample stack trace: __switch_to+0x2c0/0x450 __schedule+0x2f8/0x970 schedule+0x48/0xc0 blk_mq_freeze_queue_wait+0x94/0x120 blk_mq_queue_reinit_work+0xb8/0x180 blk_mq_queue_reinit_prepare+0x84/0xa0 cpuhp_invoke_callback+0x17c/0x600 cpuhp_up_callbacks+0x58/0x150 _cpu_up+0xf0/0x1c0 do_cpu_up+0x120/0x150 cpu_subsys_online+0x64/0xe0 device_online+0xb4/0x120 online_store+0xb4/0xc0 dev_attr_store+0x68/0xa0 sysfs_kf_write+0x80/0xb0 kernfs_fop_write+0x17c/0x250 __vfs_write+0x6c/0x1e0 vfs_write+0xd0/0x270 SyS_write+0x6c/0x110 system_call+0x38/0xe0 Examination of the queue showed a single reference (no PERCPU_COUNT_BIAS, and __PERCPU_REF_DEAD, __PERCPU_REF_ATOMIC set) and no requests. However, conditions at the time of the race are count of PERCPU_COUNT_BIAS + 0 and __PERCPU_REF_DEAD and __PERCPU_REF_ATOMIC set. The fix is to make the tryget routines use an actual boolean internally instead of the atomic long result truncated to a int. Fixes: e625305b3907 percpu-refcount: make percpu_ref based on longs instead of ints Link: https://bugzilla.kernel.org/show_bug.cgi?id=190751 Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com> Reviewed-by: Jens Axboe <axboe@fb.com> Signed-off-by: Tejun Heo <tj@kernel.org> Fixes: e625305b3907 ("percpu-refcount: make percpu_ref based on longs instead of ints") Cc: stable@vger.kernel.org # v3.18+
Diffstat (limited to 'tools/testing/selftests/firmware/fw_filesystem.sh')