#ifndef __NET_NCSI_H #define __NET_NCSI_H /* * The NCSI device states seen from external. More NCSI device states are * only visible internally (in net/ncsi/internal.h). When the NCSI device * is registered, it's in ncsi_dev_state_registered state. The state * ncsi_dev_state_start is used to drive to choose active package and * channel. After that, its state is changed to ncsi_dev_state_functional. * * The state ncsi_dev_state_stop helps to shut down the currently active * package and channel while ncsi_dev_state_config helps to reconfigure * them. */ enum { ncsi_dev_state_registered = 0x0000, ncsi_dev_state_functional = 0x0100, ncsi_dev_state_probe = 0x0200, ncsi_dev_state_config = 0x0300, ncsi_dev_state_suspend = 0x0400, }; struct ncsi_dev { int state; int link_up; struct net_device *dev; void (*handler)(struct ncsi_dev *ndev); }; #ifdef CONFIG_NET_NCSI struct ncsi_dev *ncsi_register_dev(struct net_device *dev, void (*notifier)(struct ncsi_dev *nd)); int ncsi_start_dev(struct ncsi_dev *nd); void ncsi_stop_dev(struct ncsi_dev *nd); void ncsi_unregister_dev(struct ncsi_dev *nd); #else /* !CONFIG_NET_NCSI */ static inline struct ncsi_dev *ncsi_register_dev(struct net_device *dev, void (*notifier)(struct ncsi_dev *nd)) { return NULL; } static inline int ncsi_start_dev(struct ncsi_dev *nd) { return -ENOTTY; } static void ncsi_stop_dev(struct ncsi_dev *nd) { } static inline void ncsi_unregister_dev(struct ncsi_dev *nd) { } #endif /* CONFIG_NET_NCSI */ #endif /* __NET_NCSI_H */ ummaryrefslogtreecommitdiff
path: root/tools
class='cgit-panel'>diff options
AgeCommit message (Collapse)AuthorFilesLines
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
committerTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
commit07cd12945551b63ecb1a349d50a6d69d1d6feb4a (patch)
tree75f65eba7eac9277971082a2d5a4cf1370562c0c /net/sunrpc/rpcb_clnt.c
parent7ce7d89f48834cefece7804d38fc5d85382edf77 (diff)
cgroup: don't online subsystems before cgroup_name/path() are operational
While refactoring cgroup creation, a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") incorrectly onlined subsystems before the new cgroup is associated with it kernfs_node. This is fine for cgroup proper but cgroup_name/path() depend on the associated kernfs_node and if a subsystem makes the new cgroup_subsys_state visible, which they're allowed to after onlining, it can lead to NULL dereference. The current code performs cgroup creation and subsystem onlining in cgroup_create() and cgroup_mkdir() makes the cgroup and subsystems visible afterwards. There's no reason to online the subsystems early and we can simply drop cgroup_apply_control_enable() call from cgroup_create() so that the subsystems are onlined and made visible at the same time. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Fixes: a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") Cc: stable@vger.kernel.org # v4.6+
Diffstat (limited to 'net/sunrpc/rpcb_clnt.c')