/* * Copyright (c) 2011-2012 Intel Corporation. All rights reserved. * * This program is free software; you can redistribute it and/or modify it * under the terms and conditions of the GNU General Public License, * version 2, as published by the Free Software Foundation. * * This program is distributed in the hope it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. * * You should have received a copy of the GNU General Public License along with * this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. * * Maintained at www.Open-FCoE.org */ #ifndef FCOE_SYSFS #define FCOE_SYSFS #include #include #include struct fcoe_ctlr_device; struct fcoe_fcf_device; struct fcoe_sysfs_function_template { void (*get_fcoe_ctlr_link_fail)(struct fcoe_ctlr_device *); void (*get_fcoe_ctlr_vlink_fail)(struct fcoe_ctlr_device *); void (*get_fcoe_ctlr_miss_fka)(struct fcoe_ctlr_device *); void (*get_fcoe_ctlr_symb_err)(struct fcoe_ctlr_device *); void (*get_fcoe_ctlr_err_block)(struct fcoe_ctlr_device *); void (*get_fcoe_ctlr_fcs_error)(struct fcoe_ctlr_device *); void (*set_fcoe_ctlr_mode)(struct fcoe_ctlr_device *); int (*set_fcoe_ctlr_enabled)(struct fcoe_ctlr_device *); void (*get_fcoe_fcf_selected)(struct fcoe_fcf_device *); void (*get_fcoe_fcf_vlan_id)(struct fcoe_fcf_device *); }; #define dev_to_ctlr(d) \ container_of((d), struct fcoe_ctlr_device, dev) enum fip_conn_type { FIP_CONN_TYPE_UNKNOWN, FIP_CONN_TYPE_FABRIC, FIP_CONN_TYPE_VN2VN, }; enum ctlr_enabled_state { FCOE_CTLR_ENABLED, FCOE_CTLR_DISABLED, FCOE_CTLR_UNUSED, }; struct fcoe_ctlr_device { u32 id; struct device dev; struct fcoe_sysfs_function_template *f; struct list_head fcfs; char work_q_name[20]; struct workqueue_struct *work_q; char devloss_work_q_name[20]; struct workqueue_struct *devloss_work_q; struct mutex lock; int fcf_dev_loss_tmo; enum fip_conn_type mode; enum ctlr_enabled_state enabled; /* expected in host order for displaying */ struct fcoe_fc_els_lesb lesb; }; static inline void *fcoe_ctlr_device_priv(const struct fcoe_ctlr_device *ctlr) { return (void *)(ctlr + 1); } /* fcf states */ enum fcf_state { FCOE_FCF_STATE_UNKNOWN, FCOE_FCF_STATE_DISCONNECTED, FCOE_FCF_STATE_CONNECTED, FCOE_FCF_STATE_DELETED, }; struct fcoe_fcf_device { u32 id; struct device dev; struct list_head peers; struct work_struct delete_work; struct delayed_work dev_loss_work; u32 dev_loss_tmo; void *priv; enum fcf_state state; u64 fabric_name; u64 switch_name; u32 fc_map; u16 vfid; u8 mac[ETH_ALEN]; u8 priority; u32 fka_period; u8 selected; u16 vlan_id; }; #define dev_to_fcf(d) \ container_of((d), struct fcoe_fcf_device, dev) /* parentage should never be missing */ #define fcoe_fcf_dev_to_ctlr_dev(x) \ dev_to_ctlr((x)->dev.parent) #define fcoe_fcf_device_priv(x) \ ((x)->priv) struct fcoe_ctlr_device *fcoe_ctlr_device_add(struct device *parent, struct fcoe_sysfs_function_template *f, int priv_size); void fcoe_ctlr_device_delete(struct fcoe_ctlr_device *); struct fcoe_fcf_device *fcoe_fcf_device_add(struct fcoe_ctlr_device *, struct fcoe_fcf_device *); void fcoe_fcf_device_delete(struct fcoe_fcf_device *); int __init fcoe_sysfs_setup(void); void __exit fcoe_sysfs_teardown(void); #endif /* FCOE_SYSFS */ '9'>9space:mode:
authorSriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>2017-01-09 16:00:44 +0530
committerJ. Bruce Fields <bfields@redhat.com>2017-01-12 16:14:47 -0500
commitce1ca7d2d140a1f4aaffd297ac487f246963dd2f (patch)
tree5aeab5e0cb6ef404c894a18251588278b9432a2c /include/net
parent546125d1614264d26080817d0c8cddb9b25081fa (diff)
svcrdma: avoid duplicate dma unmapping during error recovery
In rdma_read_chunk_frmr() when ib_post_send() fails, the error code path invokes ib_dma_unmap_sg() to unmap the sg list. It then invokes svc_rdma_put_frmr() which in turn tries to unmap the same sg list through ib_dma_unmap_sg() again. This second unmap is invalid and could lead to problems when the iova being unmapped is subsequently reused. Remove the call to unmap in rdma_read_chunk_frmr() and let svc_rdma_put_frmr() handle it. Fixes: 412a15c0fe53 ("svcrdma: Port to new memory registration API") Cc: stable@vger.kernel.org Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> Reviewed-by: Chuck Lever <chuck.lever@oracle.com> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'include/net')