/* * Copyright (C) 2006 Freescale Semiconductor, Inc. All rights reserved. * * Authors: Shlomi Gridish * Li Yang * * Description: * QE IC external definitions and structure. * * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License as published by the * Free Software Foundation; either version 2 of the License, or (at your * option) any later version. */ #ifndef _ASM_POWERPC_QE_IC_H #define _ASM_POWERPC_QE_IC_H #include struct device_node; struct qe_ic; #define NUM_OF_QE_IC_GROUPS 6 /* Flags when we init the QE IC */ #define QE_IC_SPREADMODE_GRP_W 0x00000001 #define QE_IC_SPREADMODE_GRP_X 0x00000002 #define QE_IC_SPREADMODE_GRP_Y 0x00000004 #define QE_IC_SPREADMODE_GRP_Z 0x00000008 #define QE_IC_SPREADMODE_GRP_RISCA 0x00000010 #define QE_IC_SPREADMODE_GRP_RISCB 0x00000020 #define QE_IC_LOW_SIGNAL 0x00000100 #define QE_IC_HIGH_SIGNAL 0x00000200 #define QE_IC_GRP_W_PRI0_DEST_SIGNAL_HIGH 0x00001000 #define QE_IC_GRP_W_PRI1_DEST_SIGNAL_HIGH 0x00002000 #define QE_IC_GRP_X_PRI0_DEST_SIGNAL_HIGH 0x00004000 #define QE_IC_GRP_X_PRI1_DEST_SIGNAL_HIGH 0x00008000 #define QE_IC_GRP_Y_PRI0_DEST_SIGNAL_HIGH 0x00010000 #define QE_IC_GRP_Y_PRI1_DEST_SIGNAL_HIGH 0x00020000 #define QE_IC_GRP_Z_PRI0_DEST_SIGNAL_HIGH 0x00040000 #define QE_IC_GRP_Z_PRI1_DEST_SIGNAL_HIGH 0x00080000 #define QE_IC_GRP_RISCA_PRI0_DEST_SIGNAL_HIGH 0x00100000 #define QE_IC_GRP_RISCA_PRI1_DEST_SIGNAL_HIGH 0x00200000 #define QE_IC_GRP_RISCB_PRI0_DEST_SIGNAL_HIGH 0x00400000 #define QE_IC_GRP_RISCB_PRI1_DEST_SIGNAL_HIGH 0x00800000 #define QE_IC_GRP_W_DEST_SIGNAL_SHIFT (12) /* QE interrupt sources groups */ enum qe_ic_grp_id { QE_IC_GRP_W = 0, /* QE interrupt controller group W */ QE_IC_GRP_X, /* QE interrupt controller group X */ QE_IC_GRP_Y, /* QE interrupt controller group Y */ QE_IC_GRP_Z, /* QE interrupt controller group Z */ QE_IC_GRP_RISCA, /* QE interrupt controller RISC group A */ QE_IC_GRP_RISCB /* QE interrupt controller RISC group B */ }; #ifdef CONFIG_QUICC_ENGINE void qe_ic_init(struct device_node *node, unsigned int flags, void (*low_handler)(struct irq_desc *desc), void (*high_handler)(struct irq_desc *desc)); unsigned int qe_ic_get_low_irq(struct qe_ic *qe_ic); unsigned int qe_ic_get_high_irq(struct qe_ic *qe_ic); #else static inline void qe_ic_init(struct device_node *node, unsigned int flags, void (*low_handler)(struct irq_desc *desc), void (*high_handler)(struct irq_desc *desc)) {} static inline unsigned int qe_ic_get_low_irq(struct qe_ic *qe_ic) { return 0; } static inline unsigned int qe_ic_get_high_irq(struct qe_ic *qe_ic) { return 0; } #endif /* CONFIG_QUICC_ENGINE */ void qe_ic_set_highest_priority(unsigned int virq, int high); int qe_ic_set_priority(unsigned int virq, unsigned int priority); int qe_ic_set_high_priority(unsigned int virq, unsigned int priority, int high); static inline void qe_ic_cascade_low_ipic(struct irq_desc *desc) { struct qe_ic *qe_ic = irq_desc_get_handler_data(desc); unsigned int cascade_irq = qe_ic_get_low_irq(qe_ic); if (cascade_irq != NO_IRQ) generic_handle_irq(cascade_irq); } static inline void qe_ic_cascade_high_ipic(struct irq_desc *desc) { struct qe_ic *qe_ic = irq_desc_get_handler_data(desc); unsigned int cascade_irq = qe_ic_get_high_irq(qe_ic); if (cascade_irq != NO_IRQ) generic_handle_irq(cascade_irq); } static inline void qe_ic_cascade_low_mpic(struct irq_desc *desc) { struct qe_ic *qe_ic = irq_desc_get_handler_data(desc); unsigned int cascade_irq = qe_ic_get_low_irq(qe_ic); struct irq_chip *chip = irq_desc_get_chip(desc); if (cascade_irq != NO_IRQ) generic_handle_irq(cascade_irq); chip->irq_eoi(&desc->irq_data); } static inline void qe_ic_cascade_high_mpic(struct irq_desc *desc) { struct qe_ic *qe_ic = irq_desc_get_handler_data(desc); unsigned int cascade_irq = qe_ic_get_high_irq(qe_ic); struct irq_chip *chip = irq_desc_get_chip(desc); if (cascade_irq != NO_IRQ) generic_handle_irq(cascade_irq); chip->irq_eoi(&desc->irq_data); } static inline void qe_ic_cascade_muxed_mpic(struct irq_desc *desc) { struct qe_ic *qe_ic = irq_desc_get_handler_data(desc); unsigned int cascade_irq; struct irq_chip *chip = irq_desc_get_chip(desc); cascade_irq = qe_ic_get_high_irq(qe_ic); if (cascade_irq == NO_IRQ) cascade_irq = qe_ic_get_low_irq(qe_ic); if (cascade_irq != NO_IRQ) generic_handle_irq(cascade_irq); chip->irq_eoi(&desc->irq_data); } #endif /* _ASM_POWERPC_QE_IC_H */ d class='right'>2017-01-29 13:50:06 -0800 committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800 commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch) tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /fs/affs/symlink.c parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/affs/symlink.c')