/* * Copyright (c) 2016, Mellanox Technologies. All rights reserved. * * This software is available to you under a choice of one of two * licenses. You may choose to be licensed under the terms of the GNU * General Public License (GPL) Version 2, available from the file * COPYING in the main directory of this source tree, or the * OpenIB.org BSD license below: * * Redistribution and use in source and binary forms, with or * without modification, are permitted provided that the following * conditions are met: * * - Redistributions of source code must retain the above * copyright notice, this list of conditions and the following * disclaimer. * * - Redistributions in binary form must reproduce the above * copyright notice, this list of conditions and the following * disclaimer in the documentation and/or other materials * provided with the distribution. * * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE * SOFTWARE. */ #ifndef SOC_NPS_COMMON_H #define SOC_NPS_COMMON_H #ifdef CONFIG_SMP #define NPS_IPI_IRQ 5 #endif #define NPS_HOST_REG_BASE 0xF6000000 #define NPS_MSU_BLKID 0x018 #define CTOP_INST_RSPI_GIC_0_R12 0x3C56117E #define CTOP_INST_MOV2B_FLIP_R3_B1_B2_INST 0x5B60 #define CTOP_INST_MOV2B_FLIP_R3_B1_B2_LIMM 0x00010422 #ifndef __ASSEMBLY__ /* In order to increase compilation test coverage */ #ifdef CONFIG_ARC static inline void nps_ack_gic(void) { __asm__ __volatile__ ( " .word %0\n" : : "i"(CTOP_INST_RSPI_GIC_0_R12) : "memory"); } #else static inline void nps_ack_gic(void) { } #define write_aux_reg(r, v) #define read_aux_reg(r) 0 #endif /* CPU global ID */ struct global_id { union { struct { #ifdef CONFIG_EZNPS_MTM_EXT u32 __reserved:20, cluster:4, core:4, thread:4; #else u32 __reserved:24, cluster:4, core:4; #endif }; u32 value; }; }; /* * Convert logical to physical CPU IDs * * The conversion swap bits 1 and 2 of cluster id (out of 4 bits) * Now quad of logical clusters id's are adjacent physically, * and not like the id's physically came with each cluster. * Below table is 4x4 mesh of core clusters as it layout on chip. * Cluster ids are in format: logical (physical) * * ----------------- ------------------ * 3 | 5 (3) 7 (7) | | 13 (11) 15 (15)| * * 2 | 4 (2) 6 (6) | | 12 (10) 14 (14)| * ----------------- ------------------ * 1 | 1 (1) 3 (5) | | 9 (9) 11 (13)| * * 0 | 0 (0) 2 (4) | | 8 (8) 10 (12)| * ----------------- ------------------ * 0 1 2 3 */ static inline int nps_cluster_logic_to_phys(int cluster) { #ifdef __arc__ __asm__ __volatile__( " mov r3,%0\n" " .short %1\n" " .word %2\n" " mov %0,r3\n" : "+r"(cluster) : "i"(CTOP_INST_MOV2B_FLIP_R3_B1_B2_INST), "i"(CTOP_INST_MOV2B_FLIP_R3_B1_B2_LIMM) : "r3"); #endif return cluster; } #define NPS_CPU_TO_CLUSTER_NUM(cpu) \ ({ struct global_id gid; gid.value = cpu; \ nps_cluster_logic_to_phys(gid.cluster); }) struct nps_host_reg_address { union { struct { u32 base:8, cl_x:4, cl_y:4, blkid:6, reg:8, __reserved:2; }; u32 value; }; }; struct nps_host_reg_address_non_cl { union { struct { u32 base:7, blkid:11, reg:12, __reserved:2; }; u32 value; }; }; static inline void *nps_host_reg_non_cl(u32 blkid, u32 reg) { struct nps_host_reg_address_non_cl reg_address; reg_address.value = NPS_HOST_REG_BASE; reg_address.blkid = blkid; reg_address.reg = reg; return (void *)reg_address.value; } static inline void *nps_host_reg(u32 cpu, u32 blkid, u32 reg) { struct nps_host_reg_address reg_address; u32 cl = NPS_CPU_TO_CLUSTER_NUM(cpu); reg_address.value = NPS_HOST_REG_BASE; reg_address.cl_x = (cl >> 2) & 0x3; reg_address.cl_y = cl & 0x3; reg_address.blkid = blkid; reg_address.reg = reg; return (void *)reg_address.value; } #endif /* __ASSEMBLY__ */ #endif /* SOC_NPS_COMMON_H */ :
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /sound/soc/samsung/s3c24xx_uda134x.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/soc/samsung/s3c24xx_uda134x.c')