/* * AESS IP block reset * * Copyright (C) 2012 Texas Instruments, Inc. * Paul Walmsley * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License as * published by the Free Software Foundation version 2. * * This program is distributed "as is" WITHOUT ANY WARRANTY of any * kind, whether express or implied; without even the implied warranty * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA * 02110-1301 USA */ #ifndef __SOUND_AESS_H__ #define __SOUND_AESS_H__ #include #include /* * AESS_AUTO_GATING_ENABLE_OFFSET: offset in bytes of the AESS IP * block's AESS_AUTO_GATING_ENABLE__1 register from the IP block's * base address */ #define AESS_AUTO_GATING_ENABLE_OFFSET 0x07c /* Register bitfields in the AESS_AUTO_GATING_ENABLE__1 register */ #define AESS_AUTO_GATING_ENABLE_SHIFT 0 /** * aess_enable_autogating - enable AESS internal autogating * @oh: struct omap_hwmod * * * Enable internal autogating on the AESS. This allows the AESS to * indicate that it is idle to the OMAP PRCM. Returns 0. */ static inline void aess_enable_autogating(void __iomem *base) { u32 v; /* Set AESS_AUTO_GATING_ENABLE__1.ENABLE to allow idle entry */ v = 1 << AESS_AUTO_GATING_ENABLE_SHIFT; writel(v, base + AESS_AUTO_GATING_ENABLE_OFFSET); } #endif /* __SOUND_AESS_H__ */ 9eb1fda2d530d3b268eef542c5414e54bf1a'>refslogtreecommitdiff
path: root/include/uapi/asm-generic/mman-common.h
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /include/uapi/asm-generic/mman-common.h
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'include/uapi/asm-generic/mman-common.h')