/* * da7218.h - DA7218 ASoC Codec Driver Platform Data * * Copyright (c) 2015 Dialog Semiconductor * * Author: Adam Thomson * * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License as published by the * Free Software Foundation; either version 2 of the License, or (at your * option) any later version. */ #ifndef _DA7218_PDATA_H #define _DA7218_PDATA_H /* Mic Bias */ enum da7218_micbias_voltage { DA7218_MICBIAS_1_2V = -1, DA7218_MICBIAS_1_6V, DA7218_MICBIAS_1_8V, DA7218_MICBIAS_2_0V, DA7218_MICBIAS_2_2V, DA7218_MICBIAS_2_4V, DA7218_MICBIAS_2_6V, DA7218_MICBIAS_2_8V, DA7218_MICBIAS_3_0V, }; enum da7218_mic_amp_in_sel { DA7218_MIC_AMP_IN_SEL_DIFF = 0, DA7218_MIC_AMP_IN_SEL_SE_P, DA7218_MIC_AMP_IN_SEL_SE_N, }; /* DMIC */ enum da7218_dmic_data_sel { DA7218_DMIC_DATA_LRISE_RFALL = 0, DA7218_DMIC_DATA_LFALL_RRISE, }; enum da7218_dmic_samplephase { DA7218_DMIC_SAMPLE_ON_CLKEDGE = 0, DA7218_DMIC_SAMPLE_BETWEEN_CLKEDGE, }; enum da7218_dmic_clk_rate { DA7218_DMIC_CLK_3_0MHZ = 0, DA7218_DMIC_CLK_1_5MHZ, }; /* Headphone Detect */ enum da7218_hpldet_jack_rate { DA7218_HPLDET_JACK_RATE_5US = 0, DA7218_HPLDET_JACK_RATE_10US, DA7218_HPLDET_JACK_RATE_20US, DA7218_HPLDET_JACK_RATE_40US, DA7218_HPLDET_JACK_RATE_80US, DA7218_HPLDET_JACK_RATE_160US, DA7218_HPLDET_JACK_RATE_320US, DA7218_HPLDET_JACK_RATE_640US, }; enum da7218_hpldet_jack_debounce { DA7218_HPLDET_JACK_DEBOUNCE_OFF = 0, DA7218_HPLDET_JACK_DEBOUNCE_2, DA7218_HPLDET_JACK_DEBOUNCE_3, DA7218_HPLDET_JACK_DEBOUNCE_4, }; enum da7218_hpldet_jack_thr { DA7218_HPLDET_JACK_THR_84PCT = 0, DA7218_HPLDET_JACK_THR_88PCT, DA7218_HPLDET_JACK_THR_92PCT, DA7218_HPLDET_JACK_THR_96PCT, }; struct da7218_hpldet_pdata { enum da7218_hpldet_jack_rate jack_rate; enum da7218_hpldet_jack_debounce jack_debounce; enum da7218_hpldet_jack_thr jack_thr; bool comp_inv; bool hyst; bool discharge; }; struct da7218_pdata { /* Mic */ enum da7218_micbias_voltage micbias1_lvl; enum da7218_micbias_voltage micbias2_lvl; enum da7218_mic_amp_in_sel mic1_amp_in_sel; enum da7218_mic_amp_in_sel mic2_amp_in_sel; /* DMIC */ enum da7218_dmic_data_sel dmic1_data_sel; enum da7218_dmic_data_sel dmic2_data_sel; enum da7218_dmic_samplephase dmic1_samplephase; enum da7218_dmic_samplephase dmic2_samplephase; enum da7218_dmic_clk_rate dmic1_clk_rate; enum da7218_dmic_clk_rate dmic2_clk_rate; /* HP Diff Supply - DA7217 only */ bool hp_diff_single_supply; /* HP Detect - DA7218 only */ struct da7218_hpldet_pdata *hpldet_pdata; }; #endif /* _DA7218_PDATA_H */ ath: root/net/sched/cls_rsvp6.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /net/sched/cls_rsvp6.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/sched/cls_rsvp6.c')