/* * Platform data for ST STA350 ASoC codec driver. * * Copyright: 2014 Raumfeld GmbH * Author: Sven Brandau * * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License as published by the * Free Software Foundation; either version 2 of the License, or (at your * option) any later version. */ #ifndef __LINUX_SND__STA350_H #define __LINUX_SND__STA350_H #define STA350_OCFG_2CH 0 #define STA350_OCFG_2_1CH 1 #define STA350_OCFG_1CH 3 #define STA350_OM_CH1 0 #define STA350_OM_CH2 1 #define STA350_OM_CH3 2 #define STA350_THERMAL_ADJUSTMENT_ENABLE 1 #define STA350_THERMAL_RECOVERY_ENABLE 2 #define STA350_FAULT_DETECT_RECOVERY_BYPASS 1 #define STA350_FFX_PM_DROP_COMP 0 #define STA350_FFX_PM_TAPERED_COMP 1 #define STA350_FFX_PM_FULL_POWER 2 #define STA350_FFX_PM_VARIABLE_DROP_COMP 3 struct sta350_platform_data { u8 output_conf; u8 ch1_output_mapping; u8 ch2_output_mapping; u8 ch3_output_mapping; u8 ffx_power_output_mode; u8 drop_compensation_ns; u8 powerdown_delay_divider; unsigned int thermal_warning_recovery:1; unsigned int thermal_warning_adjustment:1; unsigned int fault_detect_recovery:1; unsigned int oc_warning_adjustment:1; unsigned int max_power_use_mpcc:1; unsigned int max_power_correction:1; unsigned int am_reduction_mode:1; unsigned int odd_pwm_speed_mode:1; unsigned int distortion_compensation:1; unsigned int invalid_input_detect_mute:1; unsigned int activate_mute_output:1; unsigned int bridge_immediate_off:1; unsigned int noise_shape_dc_cut:1; unsigned int powerdown_master_vol:1; }; #endif /* __LINUX_SND__STA350_H */ ef542c5414e54bf1a'>refslogtreecommitdiff
path: root/include/ras
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /include/ras
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'include/ras')