#ifndef _UAPI_UVESAFB_H #define _UAPI_UVESAFB_H #include struct v86_regs { __u32 ebx; __u32 ecx; __u32 edx; __u32 esi; __u32 edi; __u32 ebp; __u32 eax; __u32 eip; __u32 eflags; __u32 esp; __u16 cs; __u16 ss; __u16 es; __u16 ds; __u16 fs; __u16 gs; }; /* Task flags */ #define TF_VBEIB 0x01 #define TF_BUF_ESDI 0x02 #define TF_BUF_ESBX 0x04 #define TF_BUF_RET 0x08 #define TF_EXIT 0x10 struct uvesafb_task { __u8 flags; int buf_len; struct v86_regs regs; }; /* Constants for the capabilities field * in vbe_ib */ #define VBE_CAP_CAN_SWITCH_DAC 0x01 #define VBE_CAP_VGACOMPAT 0x02 /* The VBE Info Block */ struct vbe_ib { char vbe_signature[4]; __u16 vbe_version; __u32 oem_string_ptr; __u32 capabilities; __u32 mode_list_ptr; __u16 total_memory; __u16 oem_software_rev; __u32 oem_vendor_name_ptr; __u32 oem_product_name_ptr; __u32 oem_product_rev_ptr; __u8 reserved[222]; char oem_data[256]; char misc_data[512]; } __attribute__ ((packed)); #endif /* _UAPI_UVESAFB_H */ n value='emaclite-cleanup'>emaclite-cleanup net-next plumbingsTobias Klauser
summaryrefslogtreecommitdiff
path: root/include/scsi/fc
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /include/scsi/fc
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'include/scsi/fc')