/* * Definitions for AUO-K190X framebuffer drivers * * Copyright (C) 2012 Heiko Stuebner * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ #ifndef _LINUX_VIDEO_AUO_K190XFB_H_ #define _LINUX_VIDEO_AUO_K190XFB_H_ /* Controller standby command needs a param */ #define AUOK190X_QUIRK_STANDBYPARAM (1 << 0) /* Controller standby is completely broken */ #define AUOK190X_QUIRK_STANDBYBROKEN (1 << 1) /* * Resolutions for the displays */ #define AUOK190X_RESOLUTION_800_600 0 #define AUOK190X_RESOLUTION_1024_768 1 #define AUOK190X_RESOLUTION_600_800 4 #define AUOK190X_RESOLUTION_768_1024 5 /* * struct used by auok190x. board specific stuff comes from *board */ struct auok190xfb_par { struct fb_info *info; struct auok190x_board *board; struct regulator *regulator; struct mutex io_lock; struct delayed_work work; wait_queue_head_t waitq; int resolution; int rotation; int consecutive_threshold; int update_cnt; /* panel and controller informations */ int epd_type; int panel_size_int; int panel_size_float; int panel_model; int tcon_version; int lut_version; /* individual controller callbacks */ void (*update_partial)(struct auok190xfb_par *par, u16 y1, u16 y2); void (*update_all)(struct auok190xfb_par *par); bool (*need_refresh)(struct auok190xfb_par *par); void (*init)(struct auok190xfb_par *par); void (*recover)(struct auok190xfb_par *par); int update_mode; /* mode to use for updates */ int last_mode; /* update mode last used */ int flash; /* power management */ int autosuspend_delay; bool standby; bool manual_standby; }; /** * Board specific platform-data * @init: initialize the controller interface * @cleanup: cleanup the controller interface * @wait_for_rdy: wait until the controller is not busy anymore * @set_ctl: change an interface control * @set_hdb: write a value to the data register * @get_hdb: read a value from the data register * @setup_irq: method to setup the irq handling on the busy gpio * @gpio_nsleep: sleep gpio * @gpio_nrst: reset gpio * @gpio_nbusy: busy gpio * @resolution: one of the AUOK190X_RESOLUTION constants * @rotation: rotation of the framebuffer * @quirks: controller quirks to honor * @fps: frames per second for defio */ struct auok190x_board { int (*init)(struct auok190xfb_par *); void (*cleanup)(struct auok190xfb_par *); int (*wait_for_rdy)(struct auok190xfb_par *); void (*set_ctl)(struct auok190xfb_par *, unsigned char, u8); void (*set_hdb)(struct auok190xfb_par *, u16); u16 (*get_hdb)(struct auok190xfb_par *); int (*setup_irq)(struct fb_info *); int gpio_nsleep; int gpio_nrst; int gpio_nbusy; int resolution; int quirks; int fps; }; #endif gi/linux/net-next.git/commit/net/ipv6?id=966d2b04e070bc040319aaebfec09e0144dc3341'>ipv6/icmp.c
diff options
context:
space:
mode:
authorDouglas Miller <dougmill@linux.vnet.ibm.com>2017-01-28 06:42:20 -0600
committerTejun Heo <tj@kernel.org>2017-01-28 07:49:42 -0500
commit966d2b04e070bc040319aaebfec09e0144dc3341 (patch)
tree4b96156e3d1dd4dfd6039b7c219c9dc4616da52d /net/ipv6/icmp.c
parent1b1bc42c1692e9b62756323c675a44cb1a1f9dbd (diff)
percpu-refcount: fix reference leak during percpu-atomic transition
percpu_ref_tryget() and percpu_ref_tryget_live() should return "true" IFF they acquire a reference. But the return value from atomic_long_inc_not_zero() is a long and may have high bits set, e.g. PERCPU_COUNT_BIAS, and the return value of the tryget routines is bool so the reference may actually be acquired but the routines return "false" which results in a reference leak since the caller assumes it does not need to do a corresponding percpu_ref_put(). This was seen when performing CPU hotplug during I/O, as hangs in blk_mq_freeze_queue_wait where percpu_ref_kill (blk_mq_freeze_queue_start) raced with percpu_ref_tryget (blk_mq_timeout_work). Sample stack trace: __switch_to+0x2c0/0x450 __schedule+0x2f8/0x970 schedule+0x48/0xc0 blk_mq_freeze_queue_wait+0x94/0x120 blk_mq_queue_reinit_work+0xb8/0x180 blk_mq_queue_reinit_prepare+0x84/0xa0 cpuhp_invoke_callback+0x17c/0x600 cpuhp_up_callbacks+0x58/0x150 _cpu_up+0xf0/0x1c0 do_cpu_up+0x120/0x150 cpu_subsys_online+0x64/0xe0 device_online+0xb4/0x120 online_store+0xb4/0xc0 dev_attr_store+0x68/0xa0 sysfs_kf_write+0x80/0xb0 kernfs_fop_write+0x17c/0x250 __vfs_write+0x6c/0x1e0 vfs_write+0xd0/0x270 SyS_write+0x6c/0x110 system_call+0x38/0xe0 Examination of the queue showed a single reference (no PERCPU_COUNT_BIAS, and __PERCPU_REF_DEAD, __PERCPU_REF_ATOMIC set) and no requests. However, conditions at the time of the race are count of PERCPU_COUNT_BIAS + 0 and __PERCPU_REF_DEAD and __PERCPU_REF_ATOMIC set. The fix is to make the tryget routines use an actual boolean internally instead of the atomic long result truncated to a int. Fixes: e625305b3907 percpu-refcount: make percpu_ref based on longs instead of ints Link: https://bugzilla.kernel.org/show_bug.cgi?id=190751 Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com> Reviewed-by: Jens Axboe <axboe@fb.com> Signed-off-by: Tejun Heo <tj@kernel.org> Fixes: e625305b3907 ("percpu-refcount: make percpu_ref based on longs instead of ints") Cc: stable@vger.kernel.org # v3.18+
Diffstat (limited to 'net/ipv6/icmp.c')