/* * Phase5 CybervisionPPC (TVP4020) definitions for the Permedia2 framebuffer * driver. * * Copyright (c) 1998-1999 Ilario Nardinocchi (nardinoc@CS.UniBO.IT) * -------------------------------------------------------------------------- * $Id: cvisionppc.h,v 1.8 1999/01/28 13:18:07 illo Exp $ * -------------------------------------------------------------------------- * This file is subject to the terms and conditions of the GNU General Public * License. See the file COPYING in the main directory of this archive * for more details. */ #ifndef CVISIONPPC_H #define CVISIONPPC_H #ifndef PM2FB_H #include "pm2fb.h" #endif struct cvppc_par { unsigned char* pci_config; unsigned char* pci_bridge; u32 user_flags; }; #define CSPPC_PCI_BRIDGE 0xfffe0000 #define CSPPC_BRIDGE_ENDIAN 0x0000 #define CSPPC_BRIDGE_INT 0x0010 #define CVPPC_PCI_CONFIG 0xfffc0000 #define CVPPC_ROM_ADDRESS 0xe2000001 #define CVPPC_REGS_REGION 0xef000000 #define CVPPC_FB_APERTURE_ONE 0xe0000000 #define CVPPC_FB_APERTURE_TWO 0xe1000000 #define CVPPC_FB_SIZE 0x00800000 #define CVPPC_MEM_CONFIG_OLD 0xed61fcaa /* FIXME Fujitsu?? */ #define CVPPC_MEM_CONFIG_NEW 0xed41c532 /* FIXME USA?? */ #define CVPPC_MEMCLOCK 83000 /* in KHz */ /* CVPPC_BRIDGE_ENDIAN */ #define CSPPCF_BRIDGE_BIG_ENDIAN 0x02 /* CVPPC_BRIDGE_INT */ #define CSPPCF_BRIDGE_ACTIVE_INT2 0x01 #endif /* CVISIONPPC_H */ /***************************************************************************** * That's all folks! *****************************************************************************/ nds-private-remove'>summaryrefslogtreecommitdiff
path: root/include/sound/hdaudio.h
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /include/sound/hdaudio.h
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'include/sound/hdaudio.h')