/* * linux/drivers/video/kyro/kryo.h * * Copyright (C) 2002 STMicroelectronics * Copyright (C) 2004 Paul Mundt * * This file is subject to the terms and conditions of the GNU General Public * License. See the file COPYING in the main directory of this archive * for more details. */ #ifndef _KYRO_H #define _KYRO_H struct kyrofb_info { void __iomem *regbase; u32 palette[16]; u32 HTot; /* Hor Total Time */ u32 HFP; /* Hor Front Porch */ u32 HST; /* Hor Sync Time */ u32 HBP; /* Hor Back Porch */ s32 HSP; /* Hor Sync Polarity */ u32 VTot; /* Ver Total Time */ u32 VFP; /* Ver Front Porch */ u32 VST; /* Ver Sync Time */ u32 VBP; /* Ver Back Porch */ s32 VSP; /* Ver Sync Polarity */ u32 XRES; /* X Resolution */ u32 YRES; /* Y Resolution */ u32 VFREQ; /* Ver Frequency */ u32 PIXCLK; /* Pixel Clock */ u32 HCLK; /* Hor Clock */ /* Useful to hold depth here for Linux */ u8 PIXDEPTH; int wc_cookie; }; extern int kyro_dev_init(void); extern void kyro_dev_reset(void); extern unsigned char *kyro_dev_physical_fb_ptr(void); extern unsigned char *kyro_dev_virtual_fb_ptr(void); extern void *kyro_dev_physical_regs_ptr(void); extern void *kyro_dev_virtual_regs_ptr(void); extern unsigned int kyro_dev_fb_size(void); extern unsigned int kyro_dev_regs_size(void); extern u32 kyro_dev_overlay_offset(void); /* * benedict.gaster@superh.com * Added the follow IOCTLS for the creation of overlay services... */ #define KYRO_IOC_MAGIC 'k' #define KYRO_IOCTL_OVERLAY_CREATE _IO(KYRO_IOC_MAGIC, 0) #define KYRO_IOCTL_OVERLAY_VIEWPORT_SET _IO(KYRO_IOC_MAGIC, 1) #define KYRO_IOCTL_SET_VIDEO_MODE _IO(KYRO_IOC_MAGIC, 2) #define KYRO_IOCTL_UVSTRIDE _IO(KYRO_IOC_MAGIC, 3) #define KYRO_IOCTL_OVERLAY_OFFSET _IO(KYRO_IOC_MAGIC, 4) #define KYRO_IOCTL_STRIDE _IO(KYRO_IOC_MAGIC, 5) /* * The follow 3 structures are used to pass data from user space into the kernel * for the creation of overlay surfaces and setting the video mode. */ typedef struct _OVERLAY_CREATE { u32 ulWidth; u32 ulHeight; int bLinear; } overlay_create; typedef struct _OVERLAY_VIEWPORT_SET { u32 xOrgin; u32 yOrgin; u32 xSize; u32 ySize; } overlay_viewport_set; typedef struct _SET_VIDEO_MODE { u32 ulWidth; u32 ulHeight; u32 ulScan; u8 displayDepth; int bLinear; } set_video_mode; #endif /* _KYRO_H */ on='/cgit.cgi/linux/net-next.git/log/tools/testing/radix-tree/test.h'>
path: root/tools/testing/radix-tree/test.h
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /tools/testing/radix-tree/test.h
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'tools/testing/radix-tree/test.h')