#ifndef _UVESAFB_H #define _UVESAFB_H #include /* VBE CRTC Info Block */ struct vbe_crtc_ib { u16 horiz_total; u16 horiz_start; u16 horiz_end; u16 vert_total; u16 vert_start; u16 vert_end; u8 flags; u32 pixel_clock; u16 refresh_rate; u8 reserved[40]; } __attribute__ ((packed)); #define VBE_MODE_VGACOMPAT 0x20 #define VBE_MODE_COLOR 0x08 #define VBE_MODE_SUPPORTEDHW 0x01 #define VBE_MODE_GRAPHICS 0x10 #define VBE_MODE_LFB 0x80 #define VBE_MODE_MASK (VBE_MODE_COLOR | VBE_MODE_SUPPORTEDHW | \ VBE_MODE_GRAPHICS | VBE_MODE_LFB) /* VBE Mode Info Block */ struct vbe_mode_ib { /* for all VBE revisions */ u16 mode_attr; u8 winA_attr; u8 winB_attr; u16 win_granularity; u16 win_size; u16 winA_seg; u16 winB_seg; u32 win_func_ptr; u16 bytes_per_scan_line; /* for VBE 1.2+ */ u16 x_res; u16 y_res; u8 x_char_size; u8 y_char_size; u8 planes; u8 bits_per_pixel; u8 banks; u8 memory_model; u8 bank_size; u8 image_pages; u8 reserved1; /* Direct color fields for direct/6 and YUV/7 memory models. */ /* Offsets are bit positions of lsb in the mask. */ u8 red_len; u8 red_off; u8 green_len; u8 green_off; u8 blue_len; u8 blue_off; u8 rsvd_len; u8 rsvd_off; u8 direct_color_info; /* direct color mode attributes */ /* for VBE 2.0+ */ u32 phys_base_ptr; u8 reserved2[6]; /* for VBE 3.0+ */ u16 lin_bytes_per_scan_line; u8 bnk_image_pages; u8 lin_image_pages; u8 lin_red_len; u8 lin_red_off; u8 lin_green_len; u8 lin_green_off; u8 lin_blue_len; u8 lin_blue_off; u8 lin_rsvd_len; u8 lin_rsvd_off; u32 max_pixel_clock; u16 mode_id; u8 depth; } __attribute__ ((packed)); #define UVESAFB_DEFAULT_MODE "640x480-16" /* How long to wait for a reply from userspace [ms] */ #define UVESAFB_TIMEOUT 5000 /* Max number of concurrent tasks */ #define UVESAFB_TASKS_MAX 16 #define dac_reg (0x3c8) #define dac_val (0x3c9) struct uvesafb_pal_entry { u_char blue, green, red, pad; } __attribute__ ((packed)); struct uvesafb_ktask { struct uvesafb_task t; void *buf; struct completion *done; u32 ack; }; static int uvesafb_exec(struct uvesafb_ktask *tsk); #define UVESAFB_EXACT_RES 1 #define UVESAFB_EXACT_DEPTH 2 struct uvesafb_par { struct vbe_ib vbe_ib; /* VBE Info Block */ struct vbe_mode_ib *vbe_modes; /* list of supported VBE modes */ int vbe_modes_cnt; u8 nocrtc; u8 ypan; /* 0 - nothing, 1 - ypan, 2 - ywrap */ u8 pmi_setpal; /* PMI for palette changes */ u16 *pmi_base; /* protected mode interface location */ void *pmi_start; void *pmi_pal; u8 *vbe_state_orig; /* * original hardware state, before the * driver was loaded */ u8 *vbe_state_saved; /* state saved by fb_save_state */ int vbe_state_size; atomic_t ref_count; int mode_idx; struct vbe_crtc_ib crtc; int mtrr_handle; }; #endif /* _UVESAFB_H */ lude/net/addrconf.h
diff options
context:
space:
mode:
authorDouglas Miller <dougmill@linux.vnet.ibm.com>2017-01-28 06:42:20 -0600
committerTejun Heo <tj@kernel.org>2017-01-28 07:49:42 -0500
commit966d2b04e070bc040319aaebfec09e0144dc3341 (patch)
tree4b96156e3d1dd4dfd6039b7c219c9dc4616da52d /include/net/addrconf.h
parent1b1bc42c1692e9b62756323c675a44cb1a1f9dbd (diff)
percpu-refcount: fix reference leak during percpu-atomic transition
percpu_ref_tryget() and percpu_ref_tryget_live() should return "true" IFF they acquire a reference. But the return value from atomic_long_inc_not_zero() is a long and may have high bits set, e.g. PERCPU_COUNT_BIAS, and the return value of the tryget routines is bool so the reference may actually be acquired but the routines return "false" which results in a reference leak since the caller assumes it does not need to do a corresponding percpu_ref_put(). This was seen when performing CPU hotplug during I/O, as hangs in blk_mq_freeze_queue_wait where percpu_ref_kill (blk_mq_freeze_queue_start) raced with percpu_ref_tryget (blk_mq_timeout_work). Sample stack trace: __switch_to+0x2c0/0x450 __schedule+0x2f8/0x970 schedule+0x48/0xc0 blk_mq_freeze_queue_wait+0x94/0x120 blk_mq_queue_reinit_work+0xb8/0x180 blk_mq_queue_reinit_prepare+0x84/0xa0 cpuhp_invoke_callback+0x17c/0x600 cpuhp_up_callbacks+0x58/0x150 _cpu_up+0xf0/0x1c0 do_cpu_up+0x120/0x150 cpu_subsys_online+0x64/0xe0 device_online+0xb4/0x120 online_store+0xb4/0xc0 dev_attr_store+0x68/0xa0 sysfs_kf_write+0x80/0xb0 kernfs_fop_write+0x17c/0x250 __vfs_write+0x6c/0x1e0 vfs_write+0xd0/0x270 SyS_write+0x6c/0x110 system_call+0x38/0xe0 Examination of the queue showed a single reference (no PERCPU_COUNT_BIAS, and __PERCPU_REF_DEAD, __PERCPU_REF_ATOMIC set) and no requests. However, conditions at the time of the race are count of PERCPU_COUNT_BIAS + 0 and __PERCPU_REF_DEAD and __PERCPU_REF_ATOMIC set. The fix is to make the tryget routines use an actual boolean internally instead of the atomic long result truncated to a int. Fixes: e625305b3907 percpu-refcount: make percpu_ref based on longs instead of ints Link: https://bugzilla.kernel.org/show_bug.cgi?id=190751 Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com> Reviewed-by: Jens Axboe <axboe@fb.com> Signed-off-by: Tejun Heo <tj@kernel.org> Fixes: e625305b3907 ("percpu-refcount: make percpu_ref based on longs instead of ints") Cc: stable@vger.kernel.org # v3.18+
Diffstat (limited to 'include/net/addrconf.h')