#ifndef _UVESAFB_H #define _UVESAFB_H #include /* VBE CRTC Info Block */ struct vbe_crtc_ib { u16 horiz_total; u16 horiz_start; u16 horiz_end; u16 vert_total; u16 vert_start; u16 vert_end; u8 flags; u32 pixel_clock; u16 refresh_rate; u8 reserved[40]; } __attribute__ ((packed)); #define VBE_MODE_VGACOMPAT 0x20 #define VBE_MODE_COLOR 0x08 #define VBE_MODE_SUPPORTEDHW 0x01 #define VBE_MODE_GRAPHICS 0x10 #define VBE_MODE_LFB 0x80 #define VBE_MODE_MASK (VBE_MODE_COLOR | VBE_MODE_SUPPORTEDHW | \ VBE_MODE_GRAPHICS | VBE_MODE_LFB) /* VBE Mode Info Block */ struct vbe_mode_ib { /* for all VBE revisions */ u16 mode_attr; u8 winA_attr; u8 winB_attr; u16 win_granularity; u16 win_size; u16 winA_seg; u16 winB_seg; u32 win_func_ptr; u16 bytes_per_scan_line; /* for VBE 1.2+ */ u16 x_res; u16 y_res; u8 x_char_size; u8 y_char_size; u8 planes; u8 bits_per_pixel; u8 banks; u8 memory_model; u8 bank_size; u8 image_pages; u8 reserved1; /* Direct color fields for direct/6 and YUV/7 memory models. */ /* Offsets are bit positions of lsb in the mask. */ u8 red_len; u8 red_off; u8 green_len; u8 green_off; u8 blue_len; u8 blue_off; u8 rsvd_len; u8 rsvd_off; u8 direct_color_info; /* direct color mode attributes */ /* for VBE 2.0+ */ u32 phys_base_ptr; u8 reserved2[6]; /* for VBE 3.0+ */ u16 lin_bytes_per_scan_line; u8 bnk_image_pages; u8 lin_image_pages; u8 lin_red_len; u8 lin_red_off; u8 lin_green_len; u8 lin_green_off; u8 lin_blue_len; u8 lin_blue_off; u8 lin_rsvd_len; u8 lin_rsvd_off; u32 max_pixel_clock; u16 mode_id; u8 depth; } __attribute__ ((packed)); #define UVESAFB_DEFAULT_MODE "640x480-16" /* How long to wait for a reply from userspace [ms] */ #define UVESAFB_TIMEOUT 5000 /* Max number of concurrent tasks */ #define UVESAFB_TASKS_MAX 16 #define dac_reg (0x3c8) #define dac_val (0x3c9) struct uvesafb_pal_entry { u_char blue, green, red, pad; } __attribute__ ((packed)); struct uvesafb_ktask { struct uvesafb_task t; void *buf; struct completion *done; u32 ack; }; static int uvesafb_exec(struct uvesafb_ktask *tsk); #define UVESAFB_EXACT_RES 1 #define UVESAFB_EXACT_DEPTH 2 struct uvesafb_par { struct vbe_ib vbe_ib; /* VBE Info Block */ struct vbe_mode_ib *vbe_modes; /* list of supported VBE modes */ int vbe_modes_cnt; u8 nocrtc; u8 ypan; /* 0 - nothing, 1 - ypan, 2 - ywrap */ u8 pmi_setpal; /* PMI for palette changes */ u16 *pmi_base; /* protected mode interface location */ void *pmi_start; void *pmi_pal; u8 *vbe_state_orig; /* * original hardware state, before the * driver was loaded */ u8 *vbe_state_saved; /* state saved by fb_save_state */ int vbe_state_size; atomic_t ref_count; int mode_idx; struct vbe_crtc_ib crtc; int mtrr_handle; }; #endif /* _UVESAFB_H */ /tools/testing/selftests/sync/sync.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /tools/testing/selftests/sync/sync.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'tools/testing/selftests/sync/sync.c')