#include #include void __init_swait_queue_head(struct swait_queue_head *q, const char *name, struct lock_class_key *key) { raw_spin_lock_init(&q->lock); lockdep_set_class_and_name(&q->lock, key, name); INIT_LIST_HEAD(&q->task_list); } EXPORT_SYMBOL(__init_swait_queue_head); /* * The thing about the wake_up_state() return value; I think we can ignore it. * * If for some reason it would return 0, that means the previously waiting * task is already running, so it will observe condition true (or has already). */ void swake_up_locked(struct swait_queue_head *q) { struct swait_queue *curr; if (list_empty(&q->task_list)) return; curr = list_first_entry(&q->task_list, typeof(*curr), task_list); wake_up_process(curr->task); list_del_init(&curr->task_list); } EXPORT_SYMBOL(swake_up_locked); void swake_up(struct swait_queue_head *q) { unsigned long flags; if (!swait_active(q)) return; raw_spin_lock_irqsave(&q->lock, flags); swake_up_locked(q); raw_spin_unlock_irqrestore(&q->lock, flags); } EXPORT_SYMBOL(swake_up); /* * Does not allow usage from IRQ disabled, since we must be able to * release IRQs to guarantee bounded hold time. */ void swake_up_all(struct swait_queue_head *q) { struct swait_queue *curr; LIST_HEAD(tmp); if (!swait_active(q)) return; raw_spin_lock_irq(&q->lock); list_splice_init(&q->task_list, &tmp); while (!list_empty(&tmp)) { curr = list_first_entry(&tmp, typeof(*curr), task_list); wake_up_state(curr->task, TASK_NORMAL); list_del_init(&curr->task_list); if (list_empty(&tmp)) break; raw_spin_unlock_irq(&q->lock); raw_spin_lock_irq(&q->lock); } raw_spin_unlock_irq(&q->lock); } EXPORT_SYMBOL(swake_up_all); void __prepare_to_swait(struct swait_queue_head *q, struct swait_queue *wait) { wait->task = current; if (list_empty(&wait->task_list)) list_add(&wait->task_list, &q->task_list); } void prepare_to_swait(struct swait_queue_head *q, struct swait_queue *wait, int state) { unsigned long flags; raw_spin_lock_irqsave(&q->lock, flags); __prepare_to_swait(q, wait); set_current_state(state); raw_spin_unlock_irqrestore(&q->lock, flags); } EXPORT_SYMBOL(prepare_to_swait); long prepare_to_swait_event(struct swait_queue_head *q, struct swait_queue *wait, int state) { if (signal_pending_state(state, current)) return -ERESTARTSYS; prepare_to_swait(q, wait, state); return 0; } EXPORT_SYMBOL(prepare_to_swait_event); void __finish_swait(struct swait_queue_head *q, struct swait_queue *wait) { __set_current_state(TASK_RUNNING); if (!list_empty(&wait->task_list)) list_del_init(&wait->task_list); } void finish_swait(struct swait_queue_head *q, struct swait_queue *wait) { unsigned long flags; __set_current_state(TASK_RUNNING); if (!list_empty_careful(&wait->task_list)) { raw_spin_lock_irqsave(&q->lock, flags); list_del_init(&wait->task_list); raw_spin_unlock_irqrestore(&q->lock, flags); } } EXPORT_SYMBOL(finish_swait); ype='hidden' name='id' value='c73e44269369e936165f0f9b61f1f09a11dae01c'/>
context:
space:
mode:
authorVincent <vincent.stehle@laposte.net>2017-01-30 15:06:43 +0100
committerDavid S. Miller <davem@davemloft.net>2017-01-31 13:07:40 -0500
commitc73e44269369e936165f0f9b61f1f09a11dae01c (patch)
treee2188e900ba06302f8ed2746cb07edd3efbc5c35 /net/tipc
parent040587af31228d82c52267f717c9fcdb65f36335 (diff)
net: thunderx: avoid dereferencing xcv when NULL
This fixes the following smatch and coccinelle warnings: drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119 xcv_setup_link() error: we previously assumed 'xcv' could be null (see line 118) [smatch] drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119:16-20: ERROR: xcv is NULL but dereferenced. [coccinelle] Fixes: 6465859aba1e66a5 ("net: thunderx: Add RGMII interface type support") Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> Cc: Sunil Goutham <sgoutham@cavium.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc')