/* * linux/lib/raid6/neon.c - RAID6 syndrome calculation using ARM NEON intrinsics * * Copyright (C) 2013 Linaro Ltd * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ #include #ifdef __KERNEL__ #include #else #define kernel_neon_begin() #define kernel_neon_end() #define cpu_has_neon() (1) #endif /* * There are 2 reasons these wrappers are kept in a separate compilation unit * from the actual implementations in neonN.c (generated from neon.uc by * unroll.awk): * - the actual implementations use NEON intrinsics, and the GCC support header * (arm_neon.h) is not fully compatible (type wise) with the kernel; * - the neonN.c files are compiled with -mfpu=neon and optimization enabled, * and we have to make sure that we never use *any* NEON/VFP instructions * outside a kernel_neon_begin()/kernel_neon_end() pair. */ #define RAID6_NEON_WRAPPER(_n) \ static void raid6_neon ## _n ## _gen_syndrome(int disks, \ size_t bytes, void **ptrs) \ { \ void raid6_neon ## _n ## _gen_syndrome_real(int, \ unsigned long, void**); \ kernel_neon_begin(); \ raid6_neon ## _n ## _gen_syndrome_real(disks, \ (unsigned long)bytes, ptrs); \ kernel_neon_end(); \ } \ static void raid6_neon ## _n ## _xor_syndrome(int disks, \ int start, int stop, \ size_t bytes, void **ptrs) \ { \ void raid6_neon ## _n ## _xor_syndrome_real(int, \ int, int, unsigned long, void**); \ kernel_neon_begin(); \ raid6_neon ## _n ## _xor_syndrome_real(disks, \ start, stop, (unsigned long)bytes, ptrs); \ kernel_neon_end(); \ } \ struct raid6_calls const raid6_neonx ## _n = { \ raid6_neon ## _n ## _gen_syndrome, \ raid6_neon ## _n ## _xor_syndrome, \ raid6_have_neon, \ "neonx" #_n, \ 0 \ } static int raid6_have_neon(void) { return cpu_has_neon(); } RAID6_NEON_WRAPPER(1); RAID6_NEON_WRAPPER(2); RAID6_NEON_WRAPPER(4); RAID6_NEON_WRAPPER(8); 9d1d6feb4a'>commitdiff
path: root/net/batman-adv/bat_algo.c
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
committerTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
commit07cd12945551b63ecb1a349d50a6d69d1d6feb4a (patch)
tree75f65eba7eac9277971082a2d5a4cf1370562c0c /net/batman-adv/bat_algo.c
parent7ce7d89f48834cefece7804d38fc5d85382edf77 (diff)
cgroup: don't online subsystems before cgroup_name/path() are operational
While refactoring cgroup creation, a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") incorrectly onlined subsystems before the new cgroup is associated with it kernfs_node. This is fine for cgroup proper but cgroup_name/path() depend on the associated kernfs_node and if a subsystem makes the new cgroup_subsys_state visible, which they're allowed to after onlining, it can lead to NULL dereference. The current code performs cgroup creation and subsystem onlining in cgroup_create() and cgroup_mkdir() makes the cgroup and subsystems visible afterwards. There's no reason to online the subsystems early and we can simply drop cgroup_apply_control_enable() call from cgroup_create() so that the subsystems are onlined and made visible at the same time. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Fixes: a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") Cc: stable@vger.kernel.org # v4.6+
Diffstat (limited to 'net/batman-adv/bat_algo.c')