/* -*- linux-c -*- ------------------------------------------------------- * * * Copyright 2002 H. Peter Anvin - All Rights Reserved * Copyright 2012 Tilera Corporation - All Rights Reserved * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, Inc., 53 Temple Place Ste 330, * Boston MA 02111-1307, USA; either version 2 of the License, or * (at your option) any later version; incorporated herein by reference. * * ----------------------------------------------------------------------- */ /* * tilegx$#.c * * $#-way unrolled TILE-Gx SIMD for RAID-6 math. * * This file is postprocessed using unroll.awk. * */ #include /* Create 8 byte copies of constant byte */ # define NBYTES(x) (__insn_v1addi(0, x)) # define NSIZE 8 /* * The SHLBYTE() operation shifts each byte left by 1, *not* * rolling over into the next byte */ static inline __attribute_const__ u64 SHLBYTE(u64 v) { /* Vector One Byte Shift Left Immediate. */ return __insn_v1shli(v, 1); } /* * The MASK() operation returns 0xFF in any byte for which the high * bit is 1, 0x00 for any byte for which the high bit is 0. */ static inline __attribute_const__ u64 MASK(u64 v) { /* Vector One Byte Shift Right Signed Immediate. */ return __insn_v1shrsi(v, 7); } void raid6_tilegx$#_gen_syndrome(int disks, size_t bytes, void **ptrs) { u8 **dptr = (u8 **)ptrs; u64 *p, *q; int d, z, z0; u64 wd$$, wq$$, wp$$, w1$$, w2$$; u64 x1d = NBYTES(0x1d); u64 * z0ptr; z0 = disks - 3; /* Highest data disk */ p = (u64 *)dptr[z0+1]; /* XOR parity */ q = (u64 *)dptr[z0+2]; /* RS syndrome */ z0ptr = (u64 *)&dptr[z0][0]; for ( d = 0 ; d < bytes ; d += NSIZE*$# ) { wq$$ = wp$$ = *z0ptr++; for ( z = z0-1 ; z >= 0 ; z-- ) { wd$$ = *(u64 *)&dptr[z][d+$$*NSIZE]; wp$$ = wp$$ ^ wd$$; w2$$ = MASK(wq$$); w1$$ = SHLBYTE(wq$$); w2$$ = w2$$ & x1d; w1$$ = w1$$ ^ w2$$; wq$$ = w1$$ ^ wd$$; } *p++ = wp$$; *q++ = wq$$; } } const struct raid6_calls raid6_tilegx$# = { raid6_tilegx$#_gen_syndrome, NULL, /* XOR not yet implemented */ NULL, "tilegx$#", 0 }; 414e54bf1a'>diff
path: root/net/tipc/Makefile
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /net/tipc/Makefile
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'net/tipc/Makefile')