diff options
| author | Yotam Gigi <yotamg@mellanox.com> | 2017-01-31 15:14:29 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-02-01 11:57:33 -0500 |
| commit | fd62d9f5c575f0792f150109f1fd24a0d4b3f854 (patch) | |
| tree | d040d634401cf38fcb447c13aff26d0f492a82a1 /net | |
| parent | 4993b39ab04b083ff6ee1147e7e7f120feb6bf7f (diff) | |
net/sched: matchall: Fix configuration race
In the current version, the matchall internal state is split into two
structs: cls_matchall_head and cls_matchall_filter. This makes little
sense, as matchall instance supports only one filter, and there is no
situation where one exists and the other does not. In addition, that led
to some races when filter was deleted while packet was processed.
Unify that two structs into one, thus simplifying the process of matchall
creation and deletion. As a result, the new, delete and get callbacks have
a dummy implementation where all the work is done in destroy and change
callbacks, as was done in cls_cgroup.
Fixes: bf3994d2ed31 ("net/sched: introduce Match-all classifier")
Reported-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Yotam Gigi <yotamg@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sched/cls_matchall.c | 127 |
1 files changed, 45 insertions, 82 deletions
diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c |