#include #include #include #include #include static DEFINE_SPINLOCK(string_tree_lock); static struct rb_root string_tree = RB_ROOT; struct ceph_string *ceph_find_or_create_string(const char* str, size_t len) { struct ceph_string *cs, *exist; struct rb_node **p, *parent; int ret; exist = NULL; spin_lock(&string_tree_lock); p = &string_tree.rb_node; while (*p) { exist = rb_entry(*p, struct ceph_string, node); ret = ceph_compare_string(exist, str, len); if (ret > 0) p = &(*p)->rb_left; else if (ret < 0) p = &(*p)->rb_right; else break; exist = NULL; } if (exist && !kref_get_unless_zero(&exist->kref)) { rb_erase(&exist->node, &string_tree); RB_CLEAR_NODE(&exist->node); exist = NULL; } spin_unlock(&string_tree_lock); if (exist) return exist; cs = kmalloc(sizeof(*cs) + len + 1, GFP_NOFS); if (!cs) return NULL; kref_init(&cs->kref); cs->len = len; memcpy(cs->str, str, len); cs->str[len] = 0; retry: exist = NULL; parent = NULL; p = &string_tree.rb_node; spin_lock(&string_tree_lock); while (*p) { parent = *p; exist = rb_entry(*p, struct ceph_string, node); ret = ceph_compare_string(exist, str, len); if (ret > 0) p = &(*p)->rb_left; else if (ret < 0) p = &(*p)->rb_right; else break; exist = NULL; } ret = 0; if (!exist) { rb_link_node(&cs->node, parent, p); rb_insert_color(&cs->node, &string_tree); } else if (!kref_get_unless_zero(&exist->kref)) { rb_erase(&exist->node, &string_tree); RB_CLEAR_NODE(&exist->node); ret = -EAGAIN; } spin_unlock(&string_tree_lock); if (ret == -EAGAIN) goto retry; if (exist) { kfree(cs); cs = exist; } return cs; } EXPORT_SYMBOL(ceph_find_or_create_string); void ceph_release_string(struct kref *ref) { struct ceph_string *cs = container_of(ref, struct ceph_string, kref); spin_lock(&string_tree_lock); if (!RB_EMPTY_NODE(&cs->node)) { rb_erase(&cs->node, &string_tree); RB_CLEAR_NODE(&cs->node); } spin_unlock(&string_tree_lock); kfree_rcu(cs, rcu); } EXPORT_SYMBOL(ceph_release_string); bool ceph_strings_empty(void) { return RB_EMPTY_ROOT(&string_tree); } select name='qt'>
path: root/net
diff options
context:
space:
mode:
authorAlexei Starovoitov <ast@fb.com>2017-01-30 18:25:18 -0800
committerDavid S. Miller <davem@davemloft.net>2017-01-31 13:28:06 -0500
commit4d1ceea8516cd6adf21f6b75995e2a7d4f376f9b (patch)
tree563b680927dd7b84ab2cd78b35b51c43bd0bb352 /net
parentf8244ab55200dbe074380c3388804adff03a8a19 (diff)
net: ethtool: convert large order kmalloc allocations to vzalloc
under memory pressure 'ethtool -S' command may warn: [ 2374.385195] ethtool: page allocation failure: order:4, mode:0x242c0c0 [ 2374.405573] CPU: 12 PID: 40211 Comm: ethtool Not tainted [ 2374.423071] Call Trace: [ 2374.423076] [<ffffffff8148cb29>] dump_stack+0x4d/0x64 [ 2374.423080] [<ffffffff811667cb>] warn_alloc_failed+0xeb/0x150 [ 2374.423082] [<ffffffff81169cd3>] ? __alloc_pages_direct_compact+0x43/0xf0 [ 2374.423084] [<ffffffff8116a25c>] __alloc_pages_nodemask+0x4dc/0xbf0 [ 2374.423091] [<ffffffffa0023dc2>] ? cmd_exec+0x722/0xcd0 [mlx5_core] [ 2374.423095] [<ffffffff811b3dcc>] alloc_pages_current+0x8c/0x110 [ 2374.423097] [<ffffffff81168859>] alloc_kmem_pages+0x19/0x90 [ 2374.423099] [<ffffffff81186e5e>] kmalloc_order_trace+0x2e/0xe0 [ 2374.423101] [<ffffffff811c0084>] __kmalloc+0x204/0x220 [ 2374.423105] [<ffffffff816c269e>] dev_ethtool+0xe4e/0x1f80 [ 2374.423106] [<ffffffff816b967e>] ? dev_get_by_name_rcu+0x5e/0x80 [ 2374.423108] [<ffffffff816d6926>] dev_ioctl+0x156/0x560 [ 2374.423111] [<ffffffff811d4c68>] ? mem_cgroup_commit_charge+0x78/0x3c0 [ 2374.423117] [<ffffffff8169d542>] sock_do_ioctl+0x42/0x50 [ 2374.423119] [<ffffffff8169d9c3>] sock_ioctl+0x1b3/0x250 [ 2374.423121] [<ffffffff811f0f42>] do_vfs_ioctl+0x92/0x580 [ 2374.423123] [<ffffffff8100222b>] ? do_audit_syscall_entry+0x4b/0x70 [ 2374.423124] [<ffffffff8100287c>] ? syscall_trace_enter_phase1+0xfc/0x120 [ 2374.423126] [<ffffffff811f14a9>] SyS_ioctl+0x79/0x90 [ 2374.423127] [<ffffffff81002bb0>] do_syscall_64+0x50/0xa0 [ 2374.423129] [<ffffffff817e19bc>] entry_SYSCALL64_slow_path+0x25/0x25 ~1160 mlx5 counters ~= order 4 allocation which is unlikely to succeed under memory pressure. Convert them to vzalloc() as ethtool_get_regs() does. Also take care of drivers without counters similar to commit 67ae7cf1eeda ("ethtool: Allow zero-length register dumps again") and reduce warn_on to warn_on_once. Signed-off-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/core/ethtool.c39
1 files changed, 22 insertions, 17 deletions
diff --git a/net/core/ethtool.c b/net/core/ethtool.c