/********************************************************************* * * Filename: irproc.c * Version: 1.0 * Description: Various entries in the /proc file system * Status: Experimental. * Author: Thomas Davis, * Created at: Sat Feb 21 21:33:24 1998 * Modified at: Sun Nov 14 08:54:54 1999 * Modified by: Dag Brattli * * Copyright (c) 1998-1999, Dag Brattli * Copyright (c) 1998, Thomas Davis, , * All Rights Reserved. * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License as * published by the Free Software Foundation; either version 2 of * the License, or (at your option) any later version. * * I, Thomas Davis, provide no warranty for any of this software. * This material is provided "AS-IS" and at no charge. * ********************************************************************/ #include #include #include #include #include #include #include #include extern const struct file_operations discovery_seq_fops; extern const struct file_operations irlap_seq_fops; extern const struct file_operations irlmp_seq_fops; extern const struct file_operations irttp_seq_fops; extern const struct file_operations irias_seq_fops; struct irda_entry { const char *name; const struct file_operations *fops; }; struct proc_dir_entry *proc_irda; EXPORT_SYMBOL(proc_irda); static const struct irda_entry irda_dirs[] = { {"discovery", &discovery_seq_fops}, {"irttp", &irttp_seq_fops}, {"irlmp", &irlmp_seq_fops}, {"irlap", &irlap_seq_fops}, {"irias", &irias_seq_fops}, }; /* * Function irda_proc_register (void) * * Register irda entry in /proc file system * */ void __init irda_proc_register(void) { int i; proc_irda = proc_mkdir("irda", init_net.proc_net); if (proc_irda == NULL) return; for (i = 0; i < ARRAY_SIZE(irda_dirs); i++) (void) proc_create(irda_dirs[i].name, 0, proc_irda, irda_dirs[i].fops); } /* * Function irda_proc_unregister (void) * * Unregister irda entry in /proc file system * */ void irda_proc_unregister(void) { int i; if (proc_irda) { for (i=0; icommitter
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
committerTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
commit07cd12945551b63ecb1a349d50a6d69d1d6feb4a (patch)
tree75f65eba7eac9277971082a2d5a4cf1370562c0c /sound/soc/intel/common/sst-acpi.c
parent7ce7d89f48834cefece7804d38fc5d85382edf77 (diff)
cgroup: don't online subsystems before cgroup_name/path() are operational
While refactoring cgroup creation, a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") incorrectly onlined subsystems before the new cgroup is associated with it kernfs_node. This is fine for cgroup proper but cgroup_name/path() depend on the associated kernfs_node and if a subsystem makes the new cgroup_subsys_state visible, which they're allowed to after onlining, it can lead to NULL dereference. The current code performs cgroup creation and subsystem onlining in cgroup_create() and cgroup_mkdir() makes the cgroup and subsystems visible afterwards. There's no reason to online the subsystems early and we can simply drop cgroup_apply_control_enable() call from cgroup_create() so that the subsystems are onlined and made visible at the same time. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Fixes: a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") Cc: stable@vger.kernel.org # v4.6+
Diffstat (limited to 'sound/soc/intel/common/sst-acpi.c')