/* * Copyright (C) 2012 Intel Corporation. All rights reserved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, see . */ #ifndef __LOCAL_HCI_H #define __LOCAL_HCI_H #include struct gate_pipe_map { u8 gate; u8 pipe; }; struct hcp_message { u8 header; /* type -cmd,evt,rsp- + instruction */ u8 data[]; } __packed; struct hcp_packet { u8 header; /* cbit+pipe */ struct hcp_message message; } __packed; struct hcp_exec_waiter { wait_queue_head_t *wq; bool exec_complete; int exec_result; struct sk_buff *result_skb; }; struct hci_msg { struct list_head msg_l; struct sk_buff_head msg_frags; bool wait_response; data_exchange_cb_t cb; void *cb_context; unsigned long completion_delay; }; struct hci_create_pipe_params { u8 src_gate; u8 dest_host; u8 dest_gate; } __packed; struct hci_create_pipe_resp { u8 src_host; u8 src_gate; u8 dest_host; u8 dest_gate; u8 pipe; } __packed; struct hci_delete_pipe_noti { u8 pipe; } __packed; struct hci_all_pipe_cleared_noti { u8 host; } __packed; #define NFC_HCI_FRAGMENT 0x7f #define HCP_HEADER(type, instr) ((((type) & 0x03) << 6) | ((instr) & 0x3f)) #define HCP_MSG_GET_TYPE(header) ((header & 0xc0) >> 6) #define HCP_MSG_GET_CMD(header) (header & 0x3f) int nfc_hci_hcp_message_tx(struct nfc_hci_dev *hdev, u8 pipe, u8 type, u8 instruction, const u8 *payload, size_t payload_len, data_exchange_cb_t cb, void *cb_context, unsigned long completion_delay); void nfc_hci_hcp_message_rx(struct nfc_hci_dev *hdev, u8 pipe, u8 type, u8 instruction, struct sk_buff *skb); /* HCP headers */ #define NFC_HCI_HCP_PACKET_HEADER_LEN 1 #define NFC_HCI_HCP_MESSAGE_HEADER_LEN 1 #define NFC_HCI_HCP_HEADER_LEN 2 /* HCP types */ #define NFC_HCI_HCP_COMMAND 0x00 #define NFC_HCI_HCP_EVENT 0x01 #define NFC_HCI_HCP_RESPONSE 0x02 /* Generic commands */ #define NFC_HCI_ANY_SET_PARAMETER 0x01 #define NFC_HCI_ANY_GET_PARAMETER 0x02 #define NFC_HCI_ANY_OPEN_PIPE 0x03 #define NFC_HCI_ANY_CLOSE_PIPE 0x04 /* Reader RF commands */ #define NFC_HCI_WR_XCHG_DATA 0x10 /* Admin commands */ #define NFC_HCI_ADM_CREATE_PIPE 0x10 #define NFC_HCI_ADM_DELETE_PIPE 0x11 #define NFC_HCI_ADM_NOTIFY_PIPE_CREATED 0x12 #define NFC_HCI_ADM_NOTIFY_PIPE_DELETED 0x13 #define NFC_HCI_ADM_CLEAR_ALL_PIPE 0x14 #define NFC_HCI_ADM_NOTIFY_ALL_PIPE_CLEARED 0x15 /* Generic responses */ #define NFC_HCI_ANY_OK 0x00 #define NFC_HCI_ANY_E_NOT_CONNECTED 0x01 #define NFC_HCI_ANY_E_CMD_PAR_UNKNOWN 0x02 #define NFC_HCI_ANY_E_NOK 0x03 #define NFC_HCI_ANY_E_PIPES_FULL 0x04 #define NFC_HCI_ANY_E_REG_PAR_UNKNOWN 0x05 #define NFC_HCI_ANY_E_PIPE_NOT_OPENED 0x06 #define NFC_HCI_ANY_E_CMD_NOT_SUPPORTED 0x07 #define NFC_HCI_ANY_E_INHIBITED 0x08 #define NFC_HCI_ANY_E_TIMEOUT 0x09 #define NFC_HCI_ANY_E_REG_ACCESS_DENIED 0x0a #define NFC_HCI_ANY_E_PIPE_ACCESS_DENIED 0x0b #endif /* __LOCAL_HCI_H */ ption>space:mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /net/batman-adv/tvlv.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/batman-adv/tvlv.c')