/* sysctls for configuring RxRPC operating parameters * * Copyright (C) 2014 Red Hat, Inc. All Rights Reserved. * Written by David Howells (dhowells@redhat.com) * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public Licence * as published by the Free Software Foundation; either version * 2 of the Licence, or (at your option) any later version. */ #include #include #include #include "ar-internal.h" static struct ctl_table_header *rxrpc_sysctl_reg_table; static const unsigned int zero = 0; static const unsigned int one = 1; static const unsigned int four = 4; static const unsigned int thirtytwo = 32; static const unsigned int n_65535 = 65535; static const unsigned int n_max_acks = RXRPC_RXTX_BUFF_SIZE - 1; /* * RxRPC operating parameters. * * See Documentation/networking/rxrpc.txt and the variable definitions for more * information on the individual parameters. */ static struct ctl_table rxrpc_sysctl_table[] = { /* Values measured in milliseconds */ { .procname = "req_ack_delay", .data = &rxrpc_requested_ack_delay, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec, .extra1 = (void *)&zero, }, { .procname = "soft_ack_delay", .data = &rxrpc_soft_ack_delay, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec, .extra1 = (void *)&one, }, { .procname = "idle_ack_delay", .data = &rxrpc_idle_ack_delay, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec, .extra1 = (void *)&one, }, { .procname = "resend_timeout", .data = &rxrpc_resend_timeout, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec, .extra1 = (void *)&one, }, { .procname = "idle_conn_expiry", .data = &rxrpc_conn_idle_client_expiry, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec_ms_jiffies, .extra1 = (void *)&one, }, { .procname = "idle_conn_fast_expiry", .data = &rxrpc_conn_idle_client_fast_expiry, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec_ms_jiffies, .extra1 = (void *)&one, }, /* Values measured in seconds but used in jiffies */ { .procname = "max_call_lifetime", .data = &rxrpc_max_call_lifetime, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec, .extra1 = (void *)&one, }, /* Non-time values */ { .procname = "max_client_conns", .data = &rxrpc_max_client_connections, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = (void *)&rxrpc_reap_client_connections, }, { .procname = "reap_client_conns", .data = &rxrpc_reap_client_connections, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = (void *)&one, .extra2 = (void *)&rxrpc_max_client_connections, }, { .procname = "max_backlog", .data = &rxrpc_max_backlog, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = (void *)&four, .extra2 = (void *)&thirtytwo, }, { .procname = "rx_window_size", .data = &rxrpc_rx_window_size, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = (void *)&one, .extra2 = (void *)&n_max_acks, }, { .procname = "rx_mtu", .data = &rxrpc_rx_mtu, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = (void *)&one, .extra2 = (void *)&n_65535, }, { .procname = "rx_jumbo_max", .data = &rxrpc_rx_jumbo_max, .maxlen = sizeof(unsigned int), .mode = 0644, .proc_handler = proc_dointvec_minmax, .extra1 = (void *)&one, .extra2 = (void *)&four, }, { } }; int __init rxrpc_sysctl_init(void) { rxrpc_sysctl_reg_table = register_net_sysctl(&init_net, "net/rxrpc", rxrpc_sysctl_table); if (!rxrpc_sysctl_reg_table) return -ENOMEM; return 0; } void rxrpc_sysctl_exit(void) { if (rxrpc_sysctl_reg_table) unregister_net_sysctl_table(rxrpc_sysctl_reg_table); } n>space:mode:
authorTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
committerTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
commit07cd12945551b63ecb1a349d50a6d69d1d6feb4a (patch)
tree75f65eba7eac9277971082a2d5a4cf1370562c0c /net/netrom/nr_loopback.c
parent7ce7d89f48834cefece7804d38fc5d85382edf77 (diff)
cgroup: don't online subsystems before cgroup_name/path() are operational
While refactoring cgroup creation, a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") incorrectly onlined subsystems before the new cgroup is associated with it kernfs_node. This is fine for cgroup proper but cgroup_name/path() depend on the associated kernfs_node and if a subsystem makes the new cgroup_subsys_state visible, which they're allowed to after onlining, it can lead to NULL dereference. The current code performs cgroup creation and subsystem onlining in cgroup_create() and cgroup_mkdir() makes the cgroup and subsystems visible afterwards. There's no reason to online the subsystems early and we can simply drop cgroup_apply_control_enable() call from cgroup_create() so that the subsystems are onlined and made visible at the same time. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Fixes: a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") Cc: stable@vger.kernel.org # v4.6+
Diffstat (limited to 'net/netrom/nr_loopback.c')