/* * net/sched/em_cmp.c Simple packet data comparison ematch * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License * as published by the Free Software Foundation; either version * 2 of the License, or (at your option) any later version. * * Authors: Thomas Graf */ #include #include #include #include #include #include #include static inline int cmp_needs_transformation(struct tcf_em_cmp *cmp) { return unlikely(cmp->flags & TCF_EM_CMP_TRANS); } static int em_cmp_match(struct sk_buff *skb, struct tcf_ematch *em, struct tcf_pkt_info *info) { struct tcf_em_cmp *cmp = (struct tcf_em_cmp *) em->data; unsigned char *ptr = tcf_get_base_ptr(skb, cmp->layer) + cmp->off; u32 val = 0; if (!tcf_valid_offset(skb, ptr, cmp->align)) return 0; switch (cmp->align) { case TCF_EM_ALIGN_U8: val = *ptr; break; case TCF_EM_ALIGN_U16: val = get_unaligned_be16(ptr); if (cmp_needs_transformation(cmp)) val = be16_to_cpu(val); break; case TCF_EM_ALIGN_U32: /* Worth checking boundries? The branching seems * to get worse. Visit again. */ val = get_unaligned_be32(ptr); if (cmp_needs_transformation(cmp)) val = be32_to_cpu(val); break; default: return 0; } if (cmp->mask) val &= cmp->mask; switch (cmp->opnd) { case TCF_EM_OPND_EQ: return val == cmp->val; case TCF_EM_OPND_LT: return val < cmp->val; case TCF_EM_OPND_GT: return val > cmp->val; } return 0; } static struct tcf_ematch_ops em_cmp_ops = { .kind = TCF_EM_CMP, .datalen = sizeof(struct tcf_em_cmp), .match = em_cmp_match, .owner = THIS_MODULE, .link = LIST_HEAD_INIT(em_cmp_ops.link) }; static int __init init_em_cmp(void) { return tcf_em_register(&em_cmp_ops); } static void __exit exit_em_cmp(void) { tcf_em_unregister(&em_cmp_ops); } MODULE_LICENSE("GPL"); module_init(init_em_cmp); module_exit(exit_em_cmp); MODULE_ALIAS_TCF_EMATCH(TCF_EM_CMP); h=nds-private-remove&id=e60df62492efd0b38e9575272d4621e6739facfd'>diff
'4'>4
AgeCommit message (Expand)AuthorFilesLines
space:
mode:
authorVincent <vincent.stehle@laposte.net>2017-01-30 15:06:43 +0100
committerDavid S. Miller <davem@davemloft.net>2017-01-31 13:07:40 -0500
commitc73e44269369e936165f0f9b61f1f09a11dae01c (patch)
treee2188e900ba06302f8ed2746cb07edd3efbc5c35 /net/netrom
parent040587af31228d82c52267f717c9fcdb65f36335 (diff)
net: thunderx: avoid dereferencing xcv when NULL
This fixes the following smatch and coccinelle warnings: drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119 xcv_setup_link() error: we previously assumed 'xcv' could be null (see line 118) [smatch] drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119:16-20: ERROR: xcv is NULL but dereferenced. [coccinelle] Fixes: 6465859aba1e66a5 ("net: thunderx: Add RGMII interface type support") Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> Cc: Sunil Goutham <sgoutham@cavium.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netrom')