/* * net/sched/em_cmp.c Simple packet data comparison ematch * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License * as published by the Free Software Foundation; either version * 2 of the License, or (at your option) any later version. * * Authors: Thomas Graf */ #include #include #include #include #include #include #include static inline int cmp_needs_transformation(struct tcf_em_cmp *cmp) { return unlikely(cmp->flags & TCF_EM_CMP_TRANS); } static int em_cmp_match(struct sk_buff *skb, struct tcf_ematch *em, struct tcf_pkt_info *info) { struct tcf_em_cmp *cmp = (struct tcf_em_cmp *) em->data; unsigned char *ptr = tcf_get_base_ptr(skb, cmp->layer) + cmp->off; u32 val = 0; if (!tcf_valid_offset(skb, ptr, cmp->align)) return 0; switch (cmp->align) { case TCF_EM_ALIGN_U8: val = *ptr; break; case TCF_EM_ALIGN_U16: val = get_unaligned_be16(ptr); if (cmp_needs_transformation(cmp)) val = be16_to_cpu(val); break; case TCF_EM_ALIGN_U32: /* Worth checking boundries? The branching seems * to get worse. Visit again. */ val = get_unaligned_be32(ptr); if (cmp_needs_transformation(cmp)) val = be32_to_cpu(val); break; default: return 0; } if (cmp->mask) val &= cmp->mask; switch (cmp->opnd) { case TCF_EM_OPND_EQ: return val == cmp->val; case TCF_EM_OPND_LT: return val < cmp->val; case TCF_EM_OPND_GT: return val > cmp->val; } return 0; } static struct tcf_ematch_ops em_cmp_ops = { .kind = TCF_EM_CMP, .datalen = sizeof(struct tcf_em_cmp), .match = em_cmp_match, .owner = THIS_MODULE, .link = LIST_HEAD_INIT(em_cmp_ops.link) }; static int __init init_em_cmp(void) { return tcf_em_register(&em_cmp_ops); } static void __exit exit_em_cmp(void) { tcf_em_unregister(&em_cmp_ops); } MODULE_LICENSE("GPL"); module_init(init_em_cmp); module_exit(exit_em_cmp); MODULE_ALIAS_TCF_EMATCH(TCF_EM_CMP); c00980552fe508c'>commitdiff
path: root/net/decnet/TODO
diff options
context:
space:
mode:
authorDexuan Cui <decui@microsoft.com>2017-01-28 11:46:02 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-01-31 10:59:48 +0100
commit433e19cf33d34bb6751c874a9c00980552fe508c (patch)
treece6547ef2987fbb289fa28f03536328a42781651 /net/decnet/TODO
parent191e885a2e130e639bb0c8ee350d7047294f2ce6 (diff)
Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()
Commit a389fcfd2cb5 ("Drivers: hv: vmbus: Fix signaling logic in hv_need_to_signal_on_read()") added the proper mb(), but removed the test "prev_write_sz < pending_sz" when making the signal decision. As a result, the guest can signal the host unnecessarily, and then the host can throttle the guest because the host thinks the guest is buggy or malicious; finally the user running stress test can perceive intermittent freeze of the guest. This patch brings back the test, and properly handles the in-place consumption APIs used by NetVSC (see get_next_pkt_raw(), put_pkt_raw() and commit_rd_index()). Fixes: a389fcfd2cb5 ("Drivers: hv: vmbus: Fix signaling logic in hv_need_to_signal_on_read()") Signed-off-by: Dexuan Cui <decui@microsoft.com> Reported-by: Rolf Neugebauer <rolf.neugebauer@docker.com> Tested-by: Rolf Neugebauer <rolf.neugebauer@docker.com> Cc: "K. Y. Srinivasan" <kys@microsoft.com> Cc: Haiyang Zhang <haiyangz@microsoft.com> Cc: Stephen Hemminger <sthemmin@microsoft.com> Cc: <stable@vger.kernel.org> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/decnet/TODO')