/* net/sched/sch_ingress.c - Ingress and clsact qdisc * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License * as published by the Free Software Foundation; either version * 2 of the License, or (at your option) any later version. * * Authors: Jamal Hadi Salim 1999 */ #include #include #include #include #include #include #include static struct Qdisc *ingress_leaf(struct Qdisc *sch, unsigned long arg) { return NULL; } static unsigned long ingress_get(struct Qdisc *sch, u32 classid) { return TC_H_MIN(classid) + 1; } static bool ingress_cl_offload(u32 classid) { return true; } static unsigned long ingress_bind_filter(struct Qdisc *sch, unsigned long parent, u32 classid) { return ingress_get(sch, classid); } static void ingress_put(struct Qdisc *sch, unsigned long cl) { } static void ingress_walk(struct Qdisc *sch, struct qdisc_walker *walker) { } static struct tcf_proto __rcu **ingress_find_tcf(struct Qdisc *sch, unsigned long cl) { struct net_device *dev = qdisc_dev(sch); return &dev->ingress_cl_list; } static int ingress_init(struct Qdisc *sch, struct nlattr *opt) { net_inc_ingress_queue(); sch->flags |= TCQ_F_CPUSTATS; return 0; } static void ingress_destroy(struct Qdisc *sch) { struct net_device *dev = qdisc_dev(sch); tcf_destroy_chain(&dev->ingress_cl_list); net_dec_ingress_queue(); } static int ingress_dump(struct Qdisc *sch, struct sk_buff *skb) { struct nlattr *nest; nest = nla_nest_start(skb, TCA_OPTIONS); if (nest == NULL) goto nla_put_failure; return nla_nest_end(skb, nest); nla_put_failure: nla_nest_cancel(skb, nest); return -1; } static const struct Qdisc_class_ops ingress_class_ops = { .leaf = ingress_leaf, .get = ingress_get, .put = ingress_put, .walk = ingress_walk, .tcf_chain = ingress_find_tcf, .tcf_cl_offload = ingress_cl_offload, .bind_tcf = ingress_bind_filter, .unbind_tcf = ingress_put, }; static struct Qdisc_ops ingress_qdisc_ops __read_mostly = { .cl_ops = &ingress_class_ops, .id = "ingress", .init = ingress_init, .destroy = ingress_destroy, .dump = ingress_dump, .owner = THIS_MODULE, }; static unsigned long clsact_get(struct Qdisc *sch, u32 classid) { switch (TC_H_MIN(classid)) { case TC_H_MIN(TC_H_MIN_INGRESS): case TC_H_MIN(TC_H_MIN_EGRESS): return TC_H_MIN(classid); default: return 0; } } static bool clsact_cl_offload(u32 classid) { return TC_H_MIN(classid) == TC_H_MIN(TC_H_MIN_INGRESS); } static unsigned long clsact_bind_filter(struct Qdisc *sch, unsigned long parent, u32 classid) { return clsact_get(sch, classid); } static struct tcf_proto __rcu **clsact_find_tcf(struct Qdisc *sch, unsigned long cl) { struct net_device *dev = qdisc_dev(sch); switch (cl) { case TC_H_MIN(TC_H_MIN_INGRESS): return &dev->ingress_cl_list; case TC_H_MIN(TC_H_MIN_EGRESS): return &dev->egress_cl_list; default: return NULL; } } static int clsact_init(struct Qdisc *sch, struct nlattr *opt) { net_inc_ingress_queue(); net_inc_egress_queue(); sch->flags |= TCQ_F_CPUSTATS; return 0; } static void clsact_destroy(struct Qdisc *sch) { struct net_device *dev = qdisc_dev(sch); tcf_destroy_chain(&dev->ingress_cl_list); tcf_destroy_chain(&dev->egress_cl_list); net_dec_ingress_queue(); net_dec_egress_queue(); } static const struct Qdisc_class_ops clsact_class_ops = { .leaf = ingress_leaf, .get = clsact_get, .put = ingress_put, .walk = ingress_walk, .tcf_chain = clsact_find_tcf, .tcf_cl_offload = clsact_cl_offload, .bind_tcf = clsact_bind_filter, .unbind_tcf = ingress_put, }; static struct Qdisc_ops clsact_qdisc_ops __read_mostly = { .cl_ops = &clsact_class_ops, .id = "clsact", .init = clsact_init, .destroy = clsact_destroy, .dump = ingress_dump, .owner = THIS_MODULE, }; static int __init ingress_module_init(void) { int ret; ret = register_qdisc(&ingress_qdisc_ops); if (!ret) { ret = register_qdisc(&clsact_qdisc_ops); if (ret) unregister_qdisc(&ingress_qdisc_ops); } return ret; } static void __exit ingress_module_exit(void) { unregister_qdisc(&ingress_qdisc_ops); unregister_qdisc(&clsact_qdisc_ops); } module_init(ingress_module_init); module_exit(ingress_module_exit); MODULE_ALIAS("sch_clsact"); MODULE_LICENSE("GPL"); it info' class='commit-info'> authorVincent <vincent.stehle@laposte.net>2017-01-30 15:06:43 +0100 committerDavid S. Miller <davem@davemloft.net>2017-01-31 13:07:40 -0500 commitc73e44269369e936165f0f9b61f1f09a11dae01c (patch) treee2188e900ba06302f8ed2746cb07edd3efbc5c35 /include/net/slhc_vj.h parent040587af31228d82c52267f717c9fcdb65f36335 (diff)
net: thunderx: avoid dereferencing xcv when NULL
This fixes the following smatch and coccinelle warnings: drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119 xcv_setup_link() error: we previously assumed 'xcv' could be null (see line 118) [smatch] drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119:16-20: ERROR: xcv is NULL but dereferenced. [coccinelle] Fixes: 6465859aba1e66a5 ("net: thunderx: Add RGMII interface type support") Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> Cc: Sunil Goutham <sgoutham@cavium.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/slhc_vj.h')