/* * VMware vSockets Driver * * Copyright (C) 2013 VMware, Inc. All rights reserved. * * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License as published by the Free * Software Foundation version 2 and no later version. * * This program is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. */ #ifndef _VMCI_TRANSPORT_H_ #define _VMCI_TRANSPORT_H_ #include #include #include #include /* If the packet format changes in a release then this should change too. */ #define VMCI_TRANSPORT_PACKET_VERSION 1 /* The resource ID on which control packets are sent. */ #define VMCI_TRANSPORT_PACKET_RID 1 /* The resource ID on which control packets are sent to the hypervisor. */ #define VMCI_TRANSPORT_HYPERVISOR_PACKET_RID 15 #define VSOCK_PROTO_INVALID 0 #define VSOCK_PROTO_PKT_ON_NOTIFY (1 << 0) #define VSOCK_PROTO_ALL_SUPPORTED (VSOCK_PROTO_PKT_ON_NOTIFY) #define vmci_trans(_vsk) ((struct vmci_transport *)((_vsk)->trans)) enum vmci_transport_packet_type { VMCI_TRANSPORT_PACKET_TYPE_INVALID = 0, VMCI_TRANSPORT_PACKET_TYPE_REQUEST, VMCI_TRANSPORT_PACKET_TYPE_NEGOTIATE, VMCI_TRANSPORT_PACKET_TYPE_OFFER, VMCI_TRANSPORT_PACKET_TYPE_ATTACH, VMCI_TRANSPORT_PACKET_TYPE_WROTE, VMCI_TRANSPORT_PACKET_TYPE_READ, VMCI_TRANSPORT_PACKET_TYPE_RST, VMCI_TRANSPORT_PACKET_TYPE_SHUTDOWN, VMCI_TRANSPORT_PACKET_TYPE_WAITING_WRITE, VMCI_TRANSPORT_PACKET_TYPE_WAITING_READ, VMCI_TRANSPORT_PACKET_TYPE_REQUEST2, VMCI_TRANSPORT_PACKET_TYPE_NEGOTIATE2, VMCI_TRANSPORT_PACKET_TYPE_MAX }; struct vmci_transport_waiting_info { u64 generation; u64 offset; }; /* Control packet type for STREAM sockets. DGRAMs have no control packets nor * special packet header for data packets, they are just raw VMCI DGRAM * messages. For STREAMs, control packets are sent over the control channel * while data is written and read directly from queue pairs with no packet * format. */ struct vmci_transport_packet { struct vmci_datagram dg; u8 version; u8 type; u16 proto; u32 src_port; u32 dst_port; u32 _reserved2; union { u64 size; u64 mode; struct vmci_handle handle; struct vmci_transport_waiting_info wait; } u; }; struct vmci_transport_notify_pkt { u64 write_notify_window; u64 write_notify_min_window; bool peer_waiting_read; bool peer_waiting_write; bool peer_waiting_write_detected; bool sent_waiting_read; bool sent_waiting_write; struct vmci_transport_waiting_info peer_waiting_read_info; struct vmci_transport_waiting_info peer_waiting_write_info; u64 produce_q_generation; u64 consume_q_generation; }; struct vmci_transport_notify_pkt_q_state { u64 write_notify_window; u64 write_notify_min_window; bool peer_waiting_write; bool peer_waiting_write_detected; }; union vmci_transport_notify { struct vmci_transport_notify_pkt pkt; struct vmci_transport_notify_pkt_q_state pkt_q_state; }; /* Our transport-specific data. */ struct vmci_transport { /* For DGRAMs. */ struct vmci_handle dg_handle; /* For STREAMs. */ struct vmci_handle qp_handle; struct vmci_qp *qpair; u64 produce_size; u64 consume_size; u64 queue_pair_size; u64 queue_pair_min_size; u64 queue_pair_max_size; u32 detach_sub_id; union vmci_transport_notify notify; const struct vmci_transport_notify_ops *notify_ops; struct list_head elem; struct sock *sk; spinlock_t lock; /* protects sk. */ }; int vmci_transport_register(void); void vmci_transport_unregister(void); int vmci_transport_send_wrote_bh(struct sockaddr_vm *dst, struct sockaddr_vm *src); int vmci_transport_send_read_bh(struct sockaddr_vm *dst, struct sockaddr_vm *src); int vmci_transport_send_wrote(struct sock *sk); int vmci_transport_send_read(struct sock *sk); int vmci_transport_send_waiting_write(struct sock *sk, struct vmci_transport_waiting_info *wait); int vmci_transport_send_waiting_read(struct sock *sk, struct vmci_transport_waiting_info *wait); #endif lected='selected'>includemode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /drivers/usb/storage/datafab.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/usb/storage/datafab.c')