/* Copyright (c) 2016 Facebook * * This program is free software; you can redistribute it and/or * modify it under the terms of version 2 of the GNU General Public * License as published by the Free Software Foundation. */ #define KBUILD_MODNAME "foo" #include #include #include #include #include #include #include #include #include "bpf_helpers.h" #define DEFAULT_PKTGEN_UDP_PORT 9 #define DEBUG 0 static int tcp(void *data, uint64_t tp_off, void *data_end) { struct tcphdr *tcp = data + tp_off; if (tcp + 1 > data_end) return 0; if (tcp->dest == htons(80) || tcp->source == htons(80)) return TC_ACT_SHOT; return 0; } static int udp(void *data, uint64_t tp_off, void *data_end) { struct udphdr *udp = data + tp_off; if (udp + 1 > data_end) return 0; if (udp->dest == htons(DEFAULT_PKTGEN_UDP_PORT) || udp->source == htons(DEFAULT_PKTGEN_UDP_PORT)) { if (DEBUG) { char fmt[] = "udp port 9 indeed\n"; bpf_trace_printk(fmt, sizeof(fmt)); } return TC_ACT_SHOT; } return 0; } static int parse_ipv4(void *data, uint64_t nh_off, void *data_end) { struct iphdr *iph; uint64_t ihl_len; iph = data + nh_off; if (iph + 1 > data_end) return 0; if (ip_is_fragment(iph)) return 0; ihl_len = iph->ihl * 4; if (iph->protocol == IPPROTO_IPIP) { iph = data + nh_off + ihl_len; if (iph + 1 > data_end) return 0; ihl_len += iph->ihl * 4; } if (iph->protocol == IPPROTO_TCP) return tcp(data, nh_off + ihl_len, data_end); else if (iph->protocol == IPPROTO_UDP) return udp(data, nh_off + ihl_len, data_end); return 0; } static int parse_ipv6(void *data, uint64_t nh_off, void *data_end) { struct ipv6hdr *ip6h; struct iphdr *iph; uint64_t ihl_len = sizeof(struct ipv6hdr); uint64_t nexthdr; ip6h = data + nh_off; if (ip6h + 1 > data_end) return 0; nexthdr = ip6h->nexthdr; if (nexthdr == IPPROTO_IPIP) { iph = data + nh_off + ihl_len; if (iph + 1 > data_end) return 0; ihl_len += iph->ihl * 4; nexthdr = iph->protocol; } else if (nexthdr == IPPROTO_IPV6) { ip6h = data + nh_off + ihl_len; if (ip6h + 1 > data_end) return 0; ihl_len += sizeof(struct ipv6hdr); nexthdr = ip6h->nexthdr; } if (nexthdr == IPPROTO_TCP) return tcp(data, nh_off + ihl_len, data_end); else if (nexthdr == IPPROTO_UDP) return udp(data, nh_off + ihl_len, data_end); return 0; } struct vlan_hdr { uint16_t h_vlan_TCI; uint16_t h_vlan_encapsulated_proto; }; SEC("varlen") int handle_ingress(struct __sk_buff *skb) { void *data = (void *)(long)skb->data; struct ethhdr *eth = data; void *data_end = (void *)(long)skb->data_end; uint64_t h_proto, nh_off; nh_off = sizeof(*eth); if (data + nh_off > data_end) return 0; h_proto = eth->h_proto; if (h_proto == ETH_P_8021Q || h_proto == ETH_P_8021AD) { struct vlan_hdr *vhdr; vhdr = data + nh_off; nh_off += sizeof(struct vlan_hdr); if (data + nh_off > data_end) return 0; h_proto = vhdr->h_vlan_encapsulated_proto; } if (h_proto == ETH_P_8021Q || h_proto == ETH_P_8021AD) { struct vlan_hdr *vhdr; vhdr = data + nh_off; nh_off += sizeof(struct vlan_hdr); if (data + nh_off > data_end) return 0; h_proto = vhdr->h_vlan_encapsulated_proto; } if (h_proto == htons(ETH_P_IP)) return parse_ipv4(data, nh_off, data_end); else if (h_proto == htons(ETH_P_IPV6)) return parse_ipv6(data, nh_off, data_end); return 0; } char _license[] SEC("license") = "GPL"; e.h?h=nds-private-remove&id=39cb2c9a316e77f6dfba96c543e55b6672d5a37e'>cpuidle.h
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /include/soc/tegra/cpuidle.h
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/soc/tegra/cpuidle.h')