# # Common parameter parsing for pktgen scripts # function usage() { echo "" echo "Usage: $0 [-vx] -i ethX" echo " -i : (\$DEV) output interface/device (required)" echo " -s : (\$PKT_SIZE) packet size" echo " -d : (\$DEST_IP) destination IP" echo " -m : (\$DST_MAC) destination MAC-addr" echo " -t : (\$THREADS) threads to start" echo " -c : (\$SKB_CLONE) SKB clones send before alloc new SKB" echo " -b : (\$BURST) HW level bursting of SKBs" echo " -v : (\$VERBOSE) verbose" echo " -x : (\$DEBUG) debug" echo " -6 : (\$IP6) IPv6" echo "" } ## --- Parse command line arguments / parameters --- ## echo "Commandline options:" while getopts "s:i:d:m:t:c:b:vxh6" option; do case $option in i) # interface export DEV=$OPTARG info "Output device set to: DEV=$DEV" ;; s) export PKT_SIZE=$OPTARG info "Packet size set to: PKT_SIZE=$PKT_SIZE bytes" ;; d) # destination IP export DEST_IP=$OPTARG info "Destination IP set to: DEST_IP=$DEST_IP" ;; m) # MAC export DST_MAC=$OPTARG info "Destination MAC set to: DST_MAC=$DST_MAC" ;; t) export THREADS=$OPTARG export CPU_THREADS=$OPTARG let "CPU_THREADS -= 1" info "Number of threads to start: $THREADS (0 to $CPU_THREADS)" ;; c) export CLONE_SKB=$OPTARG info "CLONE_SKB=$CLONE_SKB" ;; b) export BURST=$OPTARG info "SKB bursting: BURST=$BURST" ;; v) export VERBOSE=yes info "Verbose mode: VERBOSE=$VERBOSE" ;; x) export DEBUG=yes info "Debug mode: DEBUG=$DEBUG" ;; 6) export IP6=6 info "IP6: IP6=$IP6" ;; h|?|*) usage; err 2 "[ERROR] Unknown parameters!!!" esac done shift $(( $OPTIND - 1 )) if [ -z "$PKT_SIZE" ]; then # NIC adds 4 bytes CRC export PKT_SIZE=60 info "Default packet size set to: set to: $PKT_SIZE bytes" fi if [ -z "$THREADS" ]; then # Zero CPU threads means one thread, because CPU numbers are zero indexed export CPU_THREADS=0 export THREADS=1 fi if [ -z "$DEV" ]; then usage err 2 "Please specify output device" fi if [ -z "$DST_MAC" ]; then warn "Missing destination MAC address" fi if [ -z "$DEST_IP" ]; then warn "Missing destination IP address" fi if [ ! -d /proc/net/pktgen ]; then info "Loading kernel module: pktgen" modprobe pktgen fi e='committer'>committer
path: root/net/ipv6/protocol.c
ue='7'>7
AgeCommit message (Expand)AuthorFilesLines
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /fs/xfs/libxfs/xfs_fs.h
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/xfs/libxfs/xfs_fs.h')