#!/usr/bin/perl # # checkincludes: find/remove files included more than once # # Copyright abandoned, 2000, Niels Kristian Bech Jensen <nkbj@image.dk>. # Copyright 2009 Luis R. Rodriguez <mcgrof@gmail.com> # # This script checks for duplicate includes. It also has support # to remove them in place. Note that this will not take into # consideration macros so you should run this only if you know # you do have real dups and do not have them under #ifdef's. You # could also just review the results. use strict; sub usage { print "Usage: checkincludes.pl [-r]\n"; print "By default we just warn of duplicates\n"; print "To remove duplicated includes in place use -r\n"; exit 1; } my $remove = 0; if ($#ARGV < 0) { usage(); } if ($#ARGV >= 1) { if ($ARGV[0] =~ /^-/) { if ($ARGV[0] eq "-r") { $remove = 1; shift; } else { usage(); } } } foreach my $file (@ARGV) { open(my $f, '<', $file) or die "Cannot open $file: $!.\n"; my %includedfiles = (); my @file_lines = (); while (<$f>) { if (m/^\s*#\s*include\s*[<"](\S*)[>"]/o) { ++$includedfiles{$1}; } push(@file_lines, $_); } close($f); if (!$remove) { foreach my $filename (keys %includedfiles) { if ($includedfiles{$filename} > 1) { print "$file: $filename is included more than once.\n"; } } next; } open($f, '>', $file) or die("Cannot write to $file: $!"); my $dups = 0; foreach (@file_lines) { if (m/^\s*#\s*include\s*[<"](\S*)[>"]/o) { foreach my $filename (keys %includedfiles) { if ($1 eq $filename) { if ($includedfiles{$filename} > 1) { $includedfiles{$filename}--; $dups++; } else { print {$f} $_; } } } } else { print {$f} $_; } } if ($dups > 0) { print "$file: removed $dups duplicate includes\n"; } close($f); } s/befs/befs.h?h=nds-private-remove&id=697d3a21615672b2bf7724a65755799260325dda'>tree</a><a href='/cgit.cgi/linux/net-next.git/commit/fs/befs/befs.h?h=nds-private-remove&id=697d3a21615672b2bf7724a65755799260325dda'>commit</a><a href='/cgit.cgi/linux/net-next.git/diff/fs/befs/befs.h?h=nds-private-remove&id=697d3a21615672b2bf7724a65755799260325dda'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/fs/befs/befs.h'> <input type='hidden' name='h' value='nds-private-remove'/><input type='hidden' name='id' value='697d3a21615672b2bf7724a65755799260325dda'/><select name='qt'> <option value='grep'>log msg</option> <option value='author'>author</option> <option value='committer'>committer</option> <option value='range'>range</option> </select> <input class='txt' type='search' size='10' name='q' value=''/> <input type='submit' value='search'/> </form> </td></tr></table> <div class='path'>path: <a href='/cgit.cgi/linux/net-next.git/log/?h=nds-private-remove&id=697d3a21615672b2bf7724a65755799260325dda'>root</a>/<a href='/cgit.cgi/linux/net-next.git/log/fs?h=nds-private-remove&id=697d3a21615672b2bf7724a65755799260325dda'>fs</a>/<a href='/cgit.cgi/linux/net-next.git/log/fs/befs?h=nds-private-remove&id=697d3a21615672b2bf7724a65755799260325dda'>befs</a>/<a href='/cgit.cgi/linux/net-next.git/log/fs/befs/befs.h?h=nds-private-remove&id=697d3a21615672b2bf7724a65755799260325dda'>befs.h</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/cgit.cgi/linux/net-next.git/log/fs/befs/befs.h?h=nds-private-remove&id=697d3a21615672b2bf7724a65755799260325dda&showmsg=1'>Expand</a>)</th><th class='left'>Author</th><th class='left'>Files</th><th class='left'>Lines</th></tr>