/// Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE /// for debugfs files. /// //# Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() //# imposes some significant overhead as compared to //# DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). // // Copyright (C): 2016 Nicolai Stange // Options: --no-includes // virtual context virtual patch virtual org virtual report @dsa@ declarer name DEFINE_SIMPLE_ATTRIBUTE; identifier dsa_fops; expression dsa_get, dsa_set, dsa_fmt; position p; @@ DEFINE_SIMPLE_ATTRIBUTE@p(dsa_fops, dsa_get, dsa_set, dsa_fmt); @dcf@ expression name, mode, parent, data; identifier dsa.dsa_fops; @@ debugfs_create_file(name, mode, parent, data, &dsa_fops) @context_dsa depends on context && dcf@ declarer name DEFINE_DEBUGFS_ATTRIBUTE; identifier dsa.dsa_fops; expression dsa.dsa_get, dsa.dsa_set, dsa.dsa_fmt; @@ * DEFINE_SIMPLE_ATTRIBUTE(dsa_fops, dsa_get, dsa_set, dsa_fmt); @patch_dcf depends on patch expression@ expression name, mode, parent, data; identifier dsa.dsa_fops; @@ - debugfs_create_file(name, mode, parent, data, &dsa_fops) + debugfs_create_file_unsafe(name, mode, parent, data, &dsa_fops) @patch_dsa depends on patch_dcf && patch@ identifier dsa.dsa_fops; expression dsa.dsa_get, dsa.dsa_set, dsa.dsa_fmt; @@ - DEFINE_SIMPLE_ATTRIBUTE(dsa_fops, dsa_get, dsa_set, dsa_fmt); + DEFINE_DEBUGFS_ATTRIBUTE(dsa_fops, dsa_get, dsa_set, dsa_fmt); @script:python depends on org && dcf@ fops << dsa.dsa_fops; p << dsa.p; @@ msg="%s should be defined with DEFINE_DEBUGFS_ATTRIBUTE" % (fops) coccilib.org.print_todo(p[0], msg) @script:python depends on report && dcf@ fops << dsa.dsa_fops; p << dsa.p; @@ msg="WARNING: %s should be defined with DEFINE_DEBUGFS_ATTRIBUTE" % (fops) coccilib.report.print_report(p[0], msg) 7b5c94eca944be9cd23dfc752'>treecommitdiff
path: root/sound/pci/mixart
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2017-01-30 13:15:41 +0100
committerBjorn Helgaas <bhelgaas@google.com>2017-02-02 10:35:46 -0600
commitdfef358bd1beb4e7b5c94eca944be9cd23dfc752 (patch)
treeb9a2afb38a4c2ac8ad31f49ec0d71fe9e5b1994c /sound/pci/mixart
parent030305d69fc6963c16003f50d7e8d74b02d0a143 (diff)
PCI/MSI: Don't apply affinity if there aren't enough vectors left
Bart reported a problem wіth an out of bounds access in the low-level IRQ affinity code, which we root caused to the qla2xxx driver assigning all its MSI-X vectors to the pre and post vectors, and not having any left for the actually spread IRQs. Fix this issue by not asking for affinity assignment when there are no vectors to assign left. Fixes: 402723ad5c62 ("PCI/MSI: Provide pci_alloc_irq_vectors_affinity()") Link: https://lkml.kernel.org/r/1485359225.3093.3.camel@sandisk.com Reported-by: Bart Van Assche <bart.vanassche@sandisk.com> Tested-by: Bart Van Assche <bart.vanassche@sandisk.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'sound/pci/mixart')