/// Use kstrdup rather than duplicating its implementation /// // Confidence: High // Copyright: (C) 2010-2012 Nicolas Palix. GPLv2. // Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6. GPLv2. // Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6. GPLv2. // URL: http://coccinelle.lip6.fr/ // Comments: // Options: --no-includes --include-headers virtual patch virtual context virtual org virtual report @depends on patch@ expression from,to; expression flag,E1,E2; statement S; @@ - to = kmalloc(strlen(from) + 1,flag); + to = kstrdup(from, flag); ... when != \(from = E1 \| to = E1 \) if (to==NULL || ...) S ... when != \(from = E2 \| to = E2 \) - strcpy(to, from); @depends on patch@ expression x,from,to; expression flag,E1,E2,E3; statement S; @@ - x = strlen(from) + 1; ... when != \( x = E1 \| from = E1 \) - to = \(kmalloc\|kzalloc\)(x,flag); + to = kstrdup(from, flag); ... when != \(x = E2 \| from = E2 \| to = E2 \) if (to==NULL || ...) S ... when != \(x = E3 \| from = E3 \| to = E3 \) - memcpy(to, from, x); // --------------------------------------------------------------------- @r1 depends on !patch exists@ expression from,to; expression flag,E1,E2; statement S; position p1,p2; @@ * to = kmalloc@p1(strlen(from) + 1,flag); ... when != \(from = E1 \| to = E1 \) if (to==NULL || ...) S ... when != \(from = E2 \| to = E2 \) * strcpy@p2(to, from); @r2 depends on !patch exists@ expression x,from,to; expression flag,E1,E2,E3; statement S; position p1,p2; @@ * x = strlen(from) + 1; ... when != \( x = E1 \| from = E1 \) * to = \(kmalloc@p1\|kzalloc@p2\)(x,flag); ... when != \(x = E2 \| from = E2 \| to = E2 \) if (to==NULL || ...) S ... when != \(x = E3 \| from = E3 \| to = E3 \) * memcpy@p2(to, from, x); @script:python depends on org@ p1 << r1.p1; p2 << r1.p2; @@ cocci.print_main("WARNING opportunity for kstrdep",p1) cocci.print_secs("strcpy",p2) @script:python depends on org@ p1 << r2.p1; p2 << r2.p2; @@ cocci.print_main("WARNING opportunity for kstrdep",p1) cocci.print_secs("memcpy",p2) @script:python depends on report@ p1 << r1.p1; p2 << r1.p2; @@ msg = "WARNING opportunity for kstrdep (strcpy on line %s)" % (p2[0].line) coccilib.report.print_report(p1[0], msg) @script:python depends on report@ p1 << r2.p1; p2 << r2.p2; @@ msg = "WARNING opportunity for kstrdep (memcpy on line %s)" % (p2[0].line) coccilib.report.print_report(p1[0], msg) n' name='id' value='11e3b725cfc282efe9d4a354153e99d86a16af08'/>
path: root/net/nfc/nci/spi.c
diff options
context:
space:
mode:
authorArd Biesheuvel <ard.biesheuvel@linaro.org>2017-01-17 13:46:29 +0000
committerHerbert Xu <herbert@gondor.apana.org.au>2017-01-23 22:41:33 +0800
commit11e3b725cfc282efe9d4a354153e99d86a16af08 (patch)
tree8b5b9e0e1bcae1ab98ee652ffb7b13b05c209bd6 /net/nfc/nci/spi.c
parentd6040764adcb5cb6de1489422411d701c158bb69 (diff)
crypto: arm64/aes-blk - honour iv_out requirement in CBC and CTR modes
Update the ARMv8 Crypto Extensions and the plain NEON AES implementations in CBC and CTR modes to return the next IV back to the skcipher API client. This is necessary for chaining to work correctly. Note that for CTR, this is only done if the request is a round multiple of the block size, since otherwise, chaining is impossible anyway. Cc: <stable@vger.kernel.org> # v3.16+ Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'net/nfc/nci/spi.c')