/// Use kstrdup rather than duplicating its implementation /// // Confidence: High // Copyright: (C) 2010-2012 Nicolas Palix. GPLv2. // Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6. GPLv2. // Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6. GPLv2. // URL: http://coccinelle.lip6.fr/ // Comments: // Options: --no-includes --include-headers virtual patch virtual context virtual org virtual report @depends on patch@ expression from,to; expression flag,E1,E2; statement S; @@ - to = kmalloc(strlen(from) + 1,flag); + to = kstrdup(from, flag); ... when != \(from = E1 \| to = E1 \) if (to==NULL || ...) S ... when != \(from = E2 \| to = E2 \) - strcpy(to, from); @depends on patch@ expression x,from,to; expression flag,E1,E2,E3; statement S; @@ - x = strlen(from) + 1; ... when != \( x = E1 \| from = E1 \) - to = \(kmalloc\|kzalloc\)(x,flag); + to = kstrdup(from, flag); ... when != \(x = E2 \| from = E2 \| to = E2 \) if (to==NULL || ...) S ... when != \(x = E3 \| from = E3 \| to = E3 \) - memcpy(to, from, x); // --------------------------------------------------------------------- @r1 depends on !patch exists@ expression from,to; expression flag,E1,E2; statement S; position p1,p2; @@ * to = kmalloc@p1(strlen(from) + 1,flag); ... when != \(from = E1 \| to = E1 \) if (to==NULL || ...) S ... when != \(from = E2 \| to = E2 \) * strcpy@p2(to, from); @r2 depends on !patch exists@ expression x,from,to; expression flag,E1,E2,E3; statement S; position p1,p2; @@ * x = strlen(from) + 1; ... when != \( x = E1 \| from = E1 \) * to = \(kmalloc@p1\|kzalloc@p2\)(x,flag); ... when != \(x = E2 \| from = E2 \| to = E2 \) if (to==NULL || ...) S ... when != \(x = E3 \| from = E3 \| to = E3 \) * memcpy@p2(to, from, x); @script:python depends on org@ p1 << r1.p1; p2 << r1.p2; @@ cocci.print_main("WARNING opportunity for kstrdep",p1) cocci.print_secs("strcpy",p2) @script:python depends on org@ p1 << r2.p1; p2 << r2.p2; @@ cocci.print_main("WARNING opportunity for kstrdep",p1) cocci.print_secs("memcpy",p2) @script:python depends on report@ p1 << r1.p1; p2 << r1.p2; @@ msg = "WARNING opportunity for kstrdep (strcpy on line %s)" % (p2[0].line) coccilib.report.print_report(p1[0], msg) @script:python depends on report@ p1 << r2.p1; p2 << r2.p2; @@ msg = "WARNING opportunity for kstrdep (memcpy on line %s)" % (p2[0].line) coccilib.report.print_report(p1[0], msg) ue='grep'>log msg
path: root/drivers/usb/misc/sisusbvga/sisusb_con.c
diff options
context:
space:
mode:
authorRicardo Ribalda <ricardo.ribalda@gmail.com>2017-02-02 20:15:16 +0100
committerWolfram Sang <wsa@the-dreams.de>2017-02-09 17:13:01 +0100
commitbbb27fc33d44e7b8d96369810654df4ee1837566 (patch)
treeb769e165ad52c0021054f1a048b62bd7e4fbec47 /drivers/usb/misc/sisusbvga/sisusb_con.c
parentf43128c75202f29ee71aa83e6c320a911137c189 (diff)
i2c: piix4: Request the SMBUS semaphore inside the mutex
SMBSLVCNT must be protected with the piix4_mutex_sb800 in order to avoid multiple buses accessing to the semaphore at the same time. Fixes: 701dc207bf55 ("i2c: piix4: Avoid race conditions with IMC") Reported-by: Jean Delvare <jdelvare@suse.de> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Signed-off-by: Jean Delvare <jdelvare@suse.de> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'drivers/usb/misc/sisusbvga/sisusb_con.c')