/// Make sure pm_runtime_* calls does not use unnecessary IS_ERR_VALUE /// // Keywords: pm_runtime // Confidence: Medium // Copyright (C) 2013 Texas Instruments Incorporated - GPLv2. // URL: http://coccinelle.lip6.fr/ // Options: --include-headers virtual patch virtual context virtual org virtual report //---------------------------------------------------------- // Detection //---------------------------------------------------------- @runtime_bad_err_handle exists@ expression ret; position p; @@ ( ret@p = \(pm_runtime_idle\| pm_runtime_suspend\| pm_runtime_autosuspend\| pm_runtime_resume\| pm_request_idle\| pm_request_resume\| pm_request_autosuspend\| pm_runtime_get\| pm_runtime_get_sync\| pm_runtime_put\| pm_runtime_put_autosuspend\| pm_runtime_put_sync\| pm_runtime_put_sync_suspend\| pm_runtime_put_sync_autosuspend\| pm_runtime_set_active\| pm_schedule_suspend\| pm_runtime_barrier\| pm_generic_runtime_suspend\| pm_generic_runtime_resume\)(...); ... IS_ERR_VALUE(ret) ... ) //---------------------------------------------------------- // For context mode //---------------------------------------------------------- @depends on context@ identifier pm_runtime_api; expression ret; position runtime_bad_err_handle.p; @@ ( ret@p = pm_runtime_api(...); ... * IS_ERR_VALUE(ret) ... ) //---------------------------------------------------------- // For patch mode //---------------------------------------------------------- @depends on patch@ identifier pm_runtime_api; expression ret; position runtime_bad_err_handle.p; @@ ( ret@p = pm_runtime_api(...); ... - IS_ERR_VALUE(ret) + ret < 0 ... ) //---------------------------------------------------------- // For org and report mode //---------------------------------------------------------- @r depends on (org || report) exists@ position p1, p2; identifier pm_runtime_api; expression ret; position runtime_bad_err_handle.p; @@ ( ret@p = pm_runtime_api@p1(...); ... IS_ERR_VALUE@p2(ret) ... ) @script:python depends on org@ p1 << r.p1; p2 << r.p2; pm_runtime_api << r.pm_runtime_api; @@ cocci.print_main(pm_runtime_api,p1) cocci.print_secs("IS_ERR_VALUE",p2) @script:python depends on report@ p1 << r.p1; p2 << r.p2; pm_runtime_api << r.pm_runtime_api; @@ msg = "%s returns < 0 as error. Unecessary IS_ERR_VALUE at line %s" % (pm_runtime_api, p2[0].line) coccilib.report.print_report(p1[0],msg) efs/io.c'>
path: root/fs/befs/io.c
diff options
context:
space:
mode:
authorJens Axboe <axboe@fb.com>2017-01-27 11:56:06 -0700
committerJens Axboe <axboe@fb.com>2017-01-27 11:56:06 -0700
commitc14024dbb156c8392908aaa822097d27c6af8ec8 (patch)
tree02f6ffa664b16bd76750c05f62708a518de2acdc /fs/befs/io.c
parent08965c2eba135bdfb6e86cf25308e01421c7e0ce (diff)
parent3b4f18843e511193e7eb616710e838f5852e661d (diff)
Merge branch 'stable/for-jens-4.10' of git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen into for-linus
Konrad writes: Please pull in your 'for-linus' branch two little fixes for Xen block front: One fix is for handling the XEN_PAGE_SIZE != PAGE_SIZE (4KB vs 64KB on ARM for example) mishandling while the other is fixing the accounting for the configuration changes.
Diffstat (limited to 'fs/befs/io.c')