/// Find missing clk_puts. /// //# This only signals a missing clk_put when there is a clk_put later //# in the same function. //# False positives can be due to loops. // // Confidence: Moderate // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2. // Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. GPLv2. // URL: http://coccinelle.lip6.fr/ // Comments: // Options: virtual context virtual org virtual report @clk@ expression e; statement S,S1; int ret; position p1,p2,p3; @@ e = clk_get@p1(...) ... when != clk_put(e) if (<+...e...+>) S ... when any when != clk_put(e) when != if (...) { ... clk_put(e); ... } ( if (ret == 0) S1 | if (...) { ... return 0; } | if (...) { ... return <+...e...+>; } | *if@p2 (...) { ... when != clk_put(e) when forall return@p3 ...; } ) ... when any clk_put(e); @script:python depends on org@ p1 << clk.p1; p2 << clk.p2; p3 << clk.p3; @@ cocci.print_main("clk_get",p1) cocci.print_secs("if",p2) cocci.print_secs("needed clk_put",p3) @script:python depends on report@ p1 << clk.p1; p2 << clk.p2; p3 << clk.p3; @@ msg = "ERROR: missing clk_put; clk_get on line %s and execution via conditional on line %s" % (p1[0].line,p2[0].line) coccilib.report.print_report(p3[0],msg) >packet-loop-back net-next plumbingsTobias Klauser
summaryrefslogtreecommitdiff
path: root/drivers/usb/phy/phy-ulpi.c
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2017-01-31 23:58:38 +0100
committerIngo Molnar <mingo@kernel.org>2017-02-01 08:37:27 +0100
commitdd86e373e09fb16b83e8adf5c48c421a4ca76468 (patch)
tree55703c2ea8584e303e342090614e0aab3509ab21 /drivers/usb/phy/phy-ulpi.c
parent0b3589be9b98994ce3d5aeca52445d1f5627c4ba (diff)
perf/x86/intel/rapl: Make package handling more robust
The package management code in RAPL relies on package mapping being available before a CPU is started. This changed with: 9d85eb9119f4 ("x86/smpboot: Make logical package management more robust") because the ACPI/BIOS information turned out to be unreliable, but that left RAPL in broken state. This was not noticed because on a regular boot all CPUs are online before RAPL is initialized. A possible fix would be to reintroduce the mess which allocates a package data structure in CPU prepare and when it turns out to already exist in starting throw it away later in the CPU online callback. But that's a horrible hack and not required at all because RAPL becomes functional for perf only in the CPU online callback. That's correct because user space is not yet informed about the CPU being onlined, so nothing caan rely on RAPL being available on that particular CPU. Move the allocation to the CPU online callback and simplify the hotplug handling. At this point the package mapping is established and correct. This also adds a missing check for available package data in the event_init() function. Reported-by: Yasuaki Ishimatsu <yasu.isimatu@gmail.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sebastian Siewior <bigeasy@linutronix.de> Cc: Stephane Eranian <eranian@google.com> Cc: Vince Weaver <vincent.weaver@maine.edu> Fixes: 9d85eb9119f4 ("x86/smpboot: Make logical package management more robust") Link: http://lkml.kernel.org/r/20170131230141.212593966@linutronix.de Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'drivers/usb/phy/phy-ulpi.c')