/// NULL check before some freeing functions is not needed.
///
/// Based on checkpatch warning
/// "kfree(NULL) is safe this check is probably not required"
/// and kfreeaddr.cocci by Julia Lawall.
///
// Copyright: (C) 2014 Fabian Frederick.  GPLv2.
// Comments: -
// Options: --no-includes --include-headers

virtual patch
virtual org
virtual report
virtual context

@r2 depends on patch@
expression E;
@@
- if (E != NULL)
(
  kfree(E);
|
  kzfree(E);
|
  debugfs_remove(E);
|
  debugfs_remove_recursive(E);
|
  usb_free_urb(E);
|
  kmem_cache_destroy(E);
|
  mempool_destroy(E);
|
  dma_pool_destroy(E);
)

@r depends on context || report || org @
expression E;
position p;
@@

* if (E != NULL)
*	\(kfree@p\|kzfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|
*         usb_free_urb@p\|kmem_cache_destroy@p\|mempool_destroy@p\|
*         dma_pool_destroy@p\)(E);

@script:python depends on org@
p << r.p;
@@

cocci.print_main("NULL check before that freeing function is not needed", p)

@script:python depends on report@
p << r.p;
@@

msg = "WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values."
coccilib.report.print_report(p[0], msg)
t> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>net-next plumbings</td><td class='sub right'>Tobias Klauser</td></tr></table>
<table class='tabs'><tr><td>
<a href='/cgit.cgi/linux/net-next.git/'>summary</a><a href='/cgit.cgi/linux/net-next.git/refs/?id=a5c02f668c36c05fbbb29d157507be4868ecd176'>refs</a><a class='active' href='/cgit.cgi/linux/net-next.git/log/?showmsg=1'>log</a><a href='/cgit.cgi/linux/net-next.git/tree/?id=a5c02f668c36c05fbbb29d157507be4868ecd176'>tree</a><a href='/cgit.cgi/linux/net-next.git/commit/?id=a5c02f668c36c05fbbb29d157507be4868ecd176'>commit</a><a href='/cgit.cgi/linux/net-next.git/diff/?id=a5c02f668c36c05fbbb29d157507be4868ecd176'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/'>
<input type='hidden' name='id' value='a5c02f668c36c05fbbb29d157507be4868ecd176'/><input type='hidden' name='showmsg' value='1'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/cgit.cgi/linux/net-next.git/log/?id=a5c02f668c36c05fbbb29d157507be4868ecd176'>Collapse</a>)</th><th class='left'>Author</th><th class='left'>Files</th><th class='left'>Lines</th></tr>
<tr class='logheader'><td><span title='2017-02-06 15:13:34 +0100'>2017-02-06</span></td><td class='logsubject'><a href='/cgit.cgi/linux/net-next.git/commit/?id=a5c02f668c36c05fbbb29d157507be4868ecd176'>can: flexcan: flexcan_poll_bus_err(): fold in do_bus_err()</a></td><td>Marc Kleine-Budde</td><td>1</td><td><span class='deletions'>-14</span>/<span class='insertions'>+7</span></td></tr>
<tr class='nohover-highlight'><td/><td colspan='5' class='logmsg'>
This patch folds in the do_bus_err() function into
flexcan_poll_bus_err().

Signed-off-by: Marc Kleine-Budde &lt;mkl@pengutronix.de&gt;


</td></tr>
<tr class='logheader'><td><span title='2017-02-06 15:13:32 +0100'>2017-02-06</span></td><td class='logsubject'><a href='/cgit.cgi/linux/net-next.git/commit/?id=238443df8154696018fd01c1a7c8fb352b9ee49e'>can: flexcan: flexcan_poll_state(): no need to initialize new_state, ↵</a></td><td>Marc Kleine-Budde</td><td>1</td><td><span class='deletions'>-1</span>/<span class='insertions'>+1</span></td></tr>
<tr class='nohover-highlight'><td/><td colspan='5' class='logmsg'>
rx_state, tx_state

This patch removed the not needed initialisation from the new_state,
rx_state, tx_state variabled.

Signed-off-by: Marc Kleine-Budde &lt;mkl@pengutronix.de&gt;


</td></tr>
<tr class='logheader'><td><span title='2017-02-06 15:13:31 +0100'>2017-02-06</span></td><td class='logsubject'><a href='/cgit.cgi/linux/net-next.git/commit/?id=d166f56bf58b64027679905a01001df9ac0764bd'>can: flexcan: do_bus_err(): convert rx_,tx_errors into bool</a></td><td>Marc Kleine-Budde</td><td>1</td><td><span class='deletions'>-7</span>/<span class='insertions'>+7</span></td></tr>
<tr class='nohover-highlight'><td/><td colspan='5' class='logmsg'>
This patch converts the rx_errors and tx_errors from int into bool
values, to reflect their actual meaning.

Signed-off-by: Marc Kleine-Budde &lt;mkl@pengutronix.de&gt;


</td></tr>
<tr class='logheader'><td><span title='2017-02-06 15:13:30 +0100'>2017-02-06</span></td><td class='logsubject'><a href='/cgit.cgi/linux/net-next.git/commit/?id=a3c11a7ac6cdd670324df39244ed1d2321bb0c9c'>can: flexcan: make declaration of devtype_data const</a></td><td>Marc Kleine-Budde</td><td>1</td><td><span class='deletions'>-4</span>/<span class='insertions'>+4</span></td></tr>
<tr class='nohover-highlight'><td/><td colspan='5' class='logmsg'>
This patch changes the declaration of the devtype data to const.

Signed-off-by: Marc Kleine-Budde &lt;mkl@pengutronix.de&gt;


</td></tr>
<tr class='logheader'><td><span title='2017-02-06 15:13:28 +0100'>2017-02-06</span></td><td class='logsubject'><a href='/cgit.cgi/linux/net-next.git/commit/?id=1c10feee3e033b898a293d813ef4a4ebfb88dba2'>can: flexcan: remove write-only member pdata of struct flexcan_priv</a></td><td>Marc Kleine-Budde</td><td>1</td><td><span class='deletions'>-2</span>/<span class='insertions'>+0</span></td></tr>
<tr class='nohover-highlight'><td/><td colspan='5' class='logmsg'>
This patch removes the write only member pdata from the struct
flexcan_priv.

Signed-off-by: Marc Kleine-Budde &lt;mkl@pengutronix.de&gt;


</td></tr>
<tr class='logheader'><td><span title='2017-02-06 15:13:27 +0100'>2017-02-06</span></td><td class='logsubject'><a href='/cgit.cgi/linux/net-next.git/commit/?id=62d1086e87223260fcdc49c232d5c2e26ff05721'>can: flexcan: add missing register definitions</a></td><td>Marc Kleine-Budde</td><td>1</td><td><span class='deletions'>-3</span>/<span class='insertions'>+10</span></td></tr>
<tr class='nohover-highlight'><td/><td colspan='5' class='logmsg'>
This patch adds some missing register definitions, which are needed in an
upcoming patch.

Signed-off-by: Marc Kleine-Budde &lt;mkl@pengutronix.de&gt;


</td></tr>
<tr class='logheader'><td><span title='2017-02-06 15:13:24 +0100'>2017-02-06</span></td><td class='logsubject'><a href='/cgit.cgi/linux/net-next.git/commit/?id=3abbac0b5dd3e3b3dfb30a4885cdde5c20e1cb83'>can: rx-offload: Add support for timestamp based irq offloading</a></td><td>Marc Kleine-Budde