/// Find missing iounmaps. /// //# This only signals a missing iounmap when there is an iounmap later //# in the same function. //# False positives can be due to loops. // // Confidence: Moderate // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2. // Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. GPLv2. // URL: http://coccinelle.lip6.fr/ // Comments: // Options: virtual context virtual org virtual report @iom@ expression e; statement S,S1; int ret; position p1,p2,p3; @@ e = \(ioremap@p1\|ioremap_nocache@p1\)(...) ... when != iounmap(e) if (<+...e...+>) S ... when any when != iounmap(e) when != if (...) { ... iounmap(e); ... } ( if (ret == 0) S1 | if (...) { ... return 0; } | if (...) { ... return <+...e...+>; } | *if@p2 (...) { ... when != iounmap(e) when forall return@p3 ...; } ) ... when any iounmap(e); @script:python depends on org@ p1 << iom.p1; p2 << iom.p2; p3 << iom.p3; @@ cocci.print_main("ioremap",p1) cocci.print_secs("if",p2) cocci.print_secs("needed iounmap",p3) @script:python depends on report@ p1 << iom.p1; p2 << iom.p2; p3 << iom.p3; @@ msg = "ERROR: missing iounmap; ioremap on line %s and execution via conditional on line %s" % (p1[0].line,p2[0].line) coccilib.report.print_report(p3[0],msg) >packet-loop-back net-next plumbingsTobias Klauser
summaryrefslogtreecommitdiff
path: root/sound/soc/txx9/Kconfig
diff options
context:
space:
mode:
authorLaura Abbott <labbott@redhat.com>2016-12-21 12:32:54 -0800
committerHerbert Xu <herbert@gondor.apana.org.au>2016-12-27 17:32:11 +0800
commit02608e02fbec04fccf2eb0cc8d8082f65c0a4286 (patch)
tree37ff0410d130cfe77185f591b07cd6403f207f0c /sound/soc/txx9/Kconfig
parent7ce7d89f48834cefece7804d38fc5d85382edf77 (diff)
crypto: testmgr - Use heap buffer for acomp test input
Christopher Covington reported a crash on aarch64 on recent Fedora kernels: kernel BUG at ./include/linux/scatterlist.h:140! Internal error: Oops - BUG: 0 [#1] PREEMPT SMP Modules linked in: CPU: 2 PID: 752 Comm: cryptomgr_test Not tainted 4.9.0-11815-ge93b1cc #162 Hardware name: linux,dummy-virt (DT) task: ffff80007c650080 task.stack: ffff800008910000 PC is at sg_init_one+0xa0/0xb8 LR is at sg_init_one+0x24/0xb8 ... [<ffff000008398db8>] sg_init_one+0xa0/0xb8 [<ffff000008350a44>] test_acomp+0x10c/0x438 [<ffff000008350e20>] alg_test_comp+0xb0/0x118 [<ffff00000834f28c>] alg_test+0x17c/0x2f0 [<ffff00000834c6a4>] cryptomgr_test+0x44/0x50 [<ffff0000080dac70>] kthread+0xf8/0x128 [<ffff000008082ec0>] ret_from_fork+0x10/0x50 The test vectors used for input are part of the kernel image. These inputs are passed as a buffer to sg_init_one which eventually blows up with BUG_ON(!virt_addr_valid(buf)). On arm64, virt_addr_valid returns false for the kernel image since virt_to_page will not return the correct page. Fix this by copying the input vectors to heap buffer before setting up the scatterlist. Reported-by: Christopher Covington <cov@codeaurora.org> Fixes: d7db7a882deb ("crypto: acomp - update testmgr with support for acomp") Signed-off-by: Laura Abbott <labbott@redhat.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'sound/soc/txx9/Kconfig')