/// Many iterators have the property that the first argument is always bound /// to a real list element, never NULL. //# False positives arise for some iterators that do not have this property, //# or in cases when the loop cursor is reassigned. The latter should only //# happen when the matched code is on the way to a loop exit (break, goto, //# or return). /// // Confidence: Moderate // Copyright: (C) 2010-2012 Nicolas Palix. GPLv2. // Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6. GPLv2. // Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6. GPLv2. // URL: http://coccinelle.lip6.fr/ // Comments: // Options: --no-includes --include-headers virtual patch virtual context virtual org virtual report @depends on patch@ iterator I; expression x,E,E1,E2; statement S,S1,S2; @@ I(x,...) { <... ( - if (x == NULL && ...) S | - if (x != NULL || ...) S | - (x == NULL) || E | - (x != NULL) && E | - (x == NULL && ...) ? E1 : E2 | - (x != NULL || ...) ? E1 - : E2 | - if (x == NULL && ...) S1 else S2 | - if (x != NULL || ...) S1 - else S2 | + BAD( x == NULL + ) | + BAD( x != NULL + ) ) ...> } @r depends on !patch exists@ iterator I; expression x,E; position p1,p2; @@ *I@p1(x,...) { ... when != x = E ( * x@p2 == NULL | * x@p2 != NULL ) ... when any } @script:python depends on org@ p1 << r.p1; p2 << r.p2; @@ cocci.print_main("iterator-bound variable",p1) cocci.print_secs("useless NULL test",p2) @script:python depends on report@ p1 << r.p1; p2 << r.p2; @@ msg = "ERROR: iterator variable bound on line %s cannot be NULL" % (p1[0].line) coccilib.report.print_report(p2[0], msg) d599c7289526eed96541a0654'>refslogtreecommitdiff
path: root/include/acpi/acrestyp.h
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2017-01-30 11:26:38 +0100
committerJiri Kosina <jkosina@suse.cz>2017-01-31 12:59:32 +0100
commit7a7b5df84b6b4e5d599c7289526eed96541a0654 (patch)
treecf7514c7ddf4410fe37ca9099a2785e1cf08fa7d /include/acpi/acrestyp.h
parent877a021e08ccb6434718c0cc781fdf943c884cc0 (diff)
HID: cp2112: fix sleep-while-atomic
A recent commit fixing DMA-buffers on stack added a shared transfer buffer protected by a spinlock. This is broken as the USB HID request callbacks can sleep. Fix this up by replacing the spinlock with a mutex. Fixes: 1ffb3c40ffb5 ("HID: cp2112: make transfer buffers DMA capable") Cc: stable <stable@vger.kernel.org> # 4.9 Signed-off-by: Johan Hovold <johan@kernel.org> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'include/acpi/acrestyp.h')