/// Many iterators have the property that the first argument is always bound
/// to a real list element, never NULL.
//# False positives arise for some iterators that do not have this property,
//# or in cases when the loop cursor is reassigned.  The latter should only
//# happen when the matched code is on the way to a loop exit (break, goto,
//# or return).
///
// Confidence: Moderate
// Copyright: (C) 2010-2012 Nicolas Palix.  GPLv2.
// Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6.  GPLv2.
// Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6.  GPLv2.
// URL: http://coccinelle.lip6.fr/
// Comments:
// Options: --no-includes --include-headers

virtual patch
virtual context
virtual org
virtual report

@depends on patch@
iterator I;
expression x,E,E1,E2;
statement S,S1,S2;
@@

I(x,...) { <...
(
- if (x == NULL && ...) S
|
- if (x != NULL || ...)
  S
|
- (x == NULL) ||
  E
|
- (x != NULL) &&
  E
|
- (x == NULL && ...) ? E1 :
  E2
|
- (x != NULL || ...) ?
  E1
- : E2
|
- if (x == NULL && ...) S1 else
  S2
|
- if (x != NULL || ...)
  S1
- else S2
|
+ BAD(
  x == NULL
+ )
|
+ BAD(
  x != NULL
+ )
)
  ...> }

@r depends on !patch exists@
iterator I;
expression x,E;
position p1,p2;
@@

*I@p1(x,...)
{ ... when != x = E
(
*  x@p2 == NULL
|
*  x@p2 != NULL
)
  ... when any
}

@script:python depends on org@
p1 << r.p1;
p2 << r.p2;
@@

cocci.print_main("iterator-bound variable",p1)
cocci.print_secs("useless NULL test",p2)

@script:python depends on report@
p1 << r.p1;
p2 << r.p2;
@@

msg = "ERROR: iterator variable bound on line %s cannot be NULL" % (p1[0].line)
coccilib.report.print_report(p2[0], msg)
fs/?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>refs</a><a href='/cgit.cgi/linux/net-next.git/log/tools/build/Makefile'>log</a><a href='/cgit.cgi/linux/net-next.git/tree/tools/build/Makefile?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>tree</a><a class='active' href='/cgit.cgi/linux/net-next.git/commit/tools/build/Makefile?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>commit</a><a href='/cgit.cgi/linux/net-next.git/diff/tools/build/Makefile?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/tools/build/Makefile'>
<input type='hidden' name='id' value='f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit.cgi/linux/net-next.git/commit/?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>root</a>/<a href='/cgit.cgi/linux/net-next.git/commit/tools?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>tools</a>/<a href='/cgit.cgi/linux/net-next.git/commit/tools/build?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>build</a>/<a href='/cgit.cgi/linux/net-next.git/commit/tools/build/Makefile?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>Makefile</a></div><div class='content'><div class='cgit-panel'><b>diff options</b><form method='get'><input type='hidden' name='id' value='f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'/><table><tr><td colspan='2'/></tr><tr><td class='label'>context:</td><td class='ctrl'><select name='context' onchange='this.form.submit();'><option value='1'>1</option><option value='2'>2</option><option value='3' selected='selected'>3</option><option value='4'>4</option><option value='5'>5</option><option value='6'>6</option><option value='7'>7</option><option value='8'>8</option><option value='9'>9</option><option value='10'>10</option><option value='15'>15</option><option value='20'>20</option><option value='25'>25</option><option value='30'>30</option><option value='35'>35</option><option value='40'>40</option></select></td></tr><tr><td class='label'>space:</td><td class='ctrl'><select name='ignorews' onchange='this.form.submit();'><option value='0' selected='selected'>include</option><option value='1'>ignore</option></select></td></tr><tr><td class='label'>mode:</td><td class='ctrl'><select name='dt' onchange='this.form.submit();'><option value='0' selected='selected'>unified</option><option value='1'>ssdiff</option><option value='2'>stat only</option></select></td></tr><tr><td/><td class='ctrl'><noscript><input type='submit' value='reload'/></noscript></td></tr></table></form></div><table summary='commit info' class='commit-info'>
<tr><th>author</th><td>Linus Torvalds &lt;torvalds@linux-foundation.org&gt;</td><td class='right'>2017-01-30 15:47:19 -0800</td></tr>
<tr><th>committer</th><td>Linus Torvalds &lt;torvalds@linux-foundation.org&gt;</td><td class='right'>2017-01-30 15:47:19 -0800</td></tr>
<tr><th>commit</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/tools/build/Makefile?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b</a> (<a href='/cgit.cgi/linux/net-next.git/patch/tools/build/Makefile?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>patch</a>)</td></tr>
<tr><th>tree</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/tree/?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>4078d3ae27d4ebb85bdcd4d84e9b9a4d059f22bb</a> /<a href='/cgit.cgi/linux/net-next.git/tree/tools/build/Makefile?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>tools/build/Makefile</a></td></tr>
<tr><th>parent</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/tools/build/Makefile?id=751321b3dd5040dc5be19bd23f985e80c914621a'>751321b3dd5040dc5be19bd23f985e80c914621a</a> (<a href='/cgit.cgi/linux/net-next.git/diff/tools/build/Makefile?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b&amp;id2=751321b3dd5040dc5be19bd23f985e80c914621a'>diff</a>)</td></tr><tr><th>parent</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/tools/build/Makefile?id=54791b276b4000b307339f269d3bf7db877d536f'>54791b276b4000b307339f269d3bf7db877d536f</a> (<a href='/cgit.cgi/linux/net-next.git/diff/tools/build/Makefile?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b&amp;id2=54791b276b4000b307339f269d3bf7db877d536f'>diff</a>)</td></tr></table>
<div class='commit-subject'>Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc</div><div class='commit-msg'>Pull sparc fixes from David Miller:
 "Several small bug fixes and tidies, along with a fix for non-resumable
  memory errors triggered by userspace"

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc:
  sparc64: Handle PIO &amp; MEM non-resumable errors.
  sparc64: Zero pages on allocation for mondo and error queues.
  sparc: Fixed typo in sstate.c. Replaced panicing with panicking
  sparc: use symbolic names for tsb indexing
</div><div class='diffstat-header'><a href='/cgit.cgi/linux/net-next.git/diff/?id=f9a42e0d58cf0fe3d902e63d4582f2ea4cd2bb8b'>Diffstat</a> (limited to 'tools/build/Makefile')</div><table summary='diffstat' class='diffstat'>