/// Find double locks. False positives may occur when some paths cannot /// occur at execution, due to the values of variables, and when there is /// an intervening function call that releases the lock. /// // Confidence: Moderate // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2. // Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2. // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2. // URL: http://coccinelle.lip6.fr/ // Comments: // Options: --no-includes --include-headers virtual org virtual report @locked@ position p1; expression E1; position p; @@ ( mutex_lock@p1 | mutex_trylock@p1 | spin_lock@p1 | spin_trylock@p1 | read_lock@p1 | read_trylock@p1 | write_lock@p1 | write_trylock@p1 ) (E1@p,...); @balanced@ position p1 != locked.p1; position locked.p; identifier lock,unlock; expression x <= locked.E1; expression E,locked.E1; expression E2; @@ if (E) { <+... when != E1 lock(E1@p,...) ...+> } ... when != E1 when != \(x = E2\|&x\) when forall if (E) { <+... when != E1 unlock@p1(E1,...) ...+> } @r depends on !balanced exists@ expression x <= locked.E1; expression locked.E1; expression E2; identifier lock; position locked.p,p1,p2; @@ lock@p1 (E1@p,...); ... when != E1 when != \(x = E2\|&x\) lock@p2 (E1,...); @script:python depends on org@ p1 << r.p1; p2 << r.p2; lock << r.lock; @@ cocci.print_main(lock,p1) cocci.print_secs("second lock",p2) @script:python depends on report@ p1 << r.p1; p2 << r.p2; lock << r.lock; @@ msg = "second lock on line %s" % (p2[0].line) coccilib.report.print_report(p1[0],msg) .git/'>summaryrefslogtreecommitdiff
path: root/net/bluetooth/hidp
diff options
context:
space:
mode:
authorJisheng Zhang <jszhang@marvell.com>2016-11-10 17:21:29 +0800
committerMark Brown <broonie@kernel.org>2016-11-11 15:38:08 +0000
commit09f2ba0b0b7c44ecea49cf69a708203b76ba5535 (patch)
tree042df33ac99f77d8b86ac427431e267c33561c35 /net/bluetooth/hidp
parent1001354ca34179f3db924eb66672442a173147dc (diff)
regulator: gpio: properly check return value of of_get_named_gpio
The function of_get_named_gpio() could return -ENOENT, -EPROBE_DEFER -EINVAL and so on. Currently, for the optional property "enable-gpio", we only check -EPROBE_DEFER, this is not enough since there may be misconfigured "enable-gpio" in the DTB, of_get_named_gpio() will return -EINVAL in this case, we should return immediately here. And for the optional property "gpios", we didn't check the return value, the driver will continue to the point where gpio_request_array() is called, it doesn't make sense to continue if we got -EPROBE_DEFER or -EINVAL here. This patch tries to address these two issues by properly checking the return value of of_get_named_gpio. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'net/bluetooth/hidp')