/// Find missing unlocks.  This semantic match considers the specific case
/// where the unlock is missing from an if branch, and there is a lock
/// before the if and an unlock after the if.  False positives are due to
/// cases where the if branch represents a case where the function is
/// supposed to exit with the lock held, or where there is some preceding
/// function call that releases the lock.
///
// Confidence: Moderate
// Copyright: (C) 2010-2012 Nicolas Palix.  GPLv2.
// Copyright: (C) 2010-2012 Julia Lawall, INRIA/LIP6.  GPLv2.
// Copyright: (C) 2010-2012 Gilles Muller, INRIA/LiP6.  GPLv2.
// URL: http://coccinelle.lip6.fr/
// Comments:
// Options: --no-includes --include-headers

virtual context
virtual org
virtual report

@prelocked@
position p1,p;
expression E1;
@@

(
mutex_lock@p1
|
mutex_trylock@p1
|
spin_lock@p1
|
spin_trylock@p1
|
read_lock@p1
|
read_trylock@p1
|
write_lock@p1
|
write_trylock@p1
|
read_lock_irq@p1
|
write_lock_irq@p1
|
read_lock_irqsave@p1
|
write_lock_irqsave@p1
|
spin_lock_irq@p1
|
spin_lock_irqsave@p1
) (E1@p,...);

@looped@
position r;
@@

for(...;...;...) { <+... return@r ...; ...+> }

@err exists@
expression E1;
position prelocked.p;
position up != prelocked.p1;
position r!=looped.r;
identifier lock,unlock;
@@

*lock(E1@p,...);
<+... when != E1
if (...) {
  ... when != E1
*  return@r ...;
}
...+>
*unlock@up(E1,...);

@script:python depends on org@
p << prelocked.p1;
lock << err.lock;
unlock << err.unlock;
p2 << err.r;
@@

cocci.print_main(lock,p)
cocci.print_secs(unlock,p2)

@script:python depends on report@
p << prelocked.p1;
lock << err.lock;
unlock << err.unlock;
p2 << err.r;
@@

msg = "preceding lock on line %s" % (p[0].line)
coccilib.report.print_report(p2[0],msg)
7b30c322531981f24833b082446072d3c79'>refs</a><a href='/cgit.cgi/linux/net-next.git/log/net/sched/sch_codel.c?h=nds-private-remove'>log</a><a href='/cgit.cgi/linux/net-next.git/tree/net/sched/sch_codel.c?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79'>tree</a><a class='active' href='/cgit.cgi/linux/net-next.git/commit/net/sched/sch_codel.c?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79'>commit</a><a href='/cgit.cgi/linux/net-next.git/diff/net/sched/sch_codel.c?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/net/sched/sch_codel.c'>
<input type='hidden' name='h' value='nds-private-remove'/><input type='hidden' name='id' value='aa2797b30c322531981f24833b082446072d3c79'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit.cgi/linux/net-next.git/commit/?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79'>root</a>/<a href='/cgit.cgi/linux/net-next.git/commit/net?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79'>net</a>/<a href='/cgit.cgi/linux/net-next.git/commit/net/sched?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79'>sched</a>/<a href='/cgit.cgi/linux/net-next.git/commit/net/sched/sch_codel.c?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79'>sch_codel.c</a></div><div class='content'><div class='cgit-panel'><b>diff options</b><form method='get'><input type='hidden' name='h' value='nds-private-remove'/><input type='hidden' name='id' value='aa2797b30c322531981f24833b082446072d3c79'/><table><tr><td colspan='2'/></tr><tr><td class='label'>context:</td><td class='ctrl'><select name='context' onchange='this.form.submit();'><option value='1'>1</option><option value='2'>2</option><option value='3' selected='selected'>3</option><option value='4'>4</option><option value='5'>5</option><option value='6'>6</option><option value='7'>7</option><option value='8'>8</option><option value='9'>9</option><option value='10'>10</option><option value='15'>15</option><option value='20'>20</option><option value='25'>25</option><option value='30'>30</option><option value='35'>35</option><option value='40'>40</option></select></td></tr><tr><td class='label'>space:</td><td class='ctrl'><select name='ignorews' onchange='this.form.submit();'><option value='0' selected='selected'>include</option><option value='1'>ignore</option></select></td></tr><tr><td class='label'>mode:</td><td class='ctrl'><select name='dt' onchange='this.form.submit();'><option value='0' selected='selected'>unified</option><option value='1'>ssdiff</option><option value='2'>stat only</option></select></td></tr><tr><td/><td class='ctrl'><noscript><input type='submit' value='reload'/></noscript></td></tr></table></form></div><table summary='commit info' class='commit-info'>
<tr><th>author</th><td>Linus Torvalds &lt;torvalds@linux-foundation.org&gt;</td><td class='right'>2017-01-15 12:28:14 -0800</td></tr>
<tr><th>committer</th><td>Linus Torvalds &lt;torvalds@linux-foundation.org&gt;</td><td class='right'>2017-01-15 12:28:14 -0800</td></tr>
<tr><th>commit</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/net/sched/sch_codel.c?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79'>aa2797b30c322531981f24833b082446072d3c79</a> (<a href='/cgit.cgi/linux/net-next.git/patch/net/sched/sch_codel.c?id=aa2797b30c322531981f24833b082446072d3c79'>patch</a>)</td></tr>
<tr><th>tree</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/tree/?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79'>d18b02adcc7cc9c79462527ac95f38a34a61dd15</a> /<a href='/cgit.cgi/linux/net-next.git/tree/net/sched/sch_codel.c?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79'>net/sched/sch_codel.c</a></td></tr>
<tr><th>parent</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/net/sched/sch_codel.c?h=nds-private-remove&amp;id=83346fbc07d267de777e2597552f785174ad0373'>83346fbc07d267de777e2597552f785174ad0373</a> (<a href='/cgit.cgi/linux/net-next.git/diff/net/sched/sch_codel.c?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79&amp;id2=83346fbc07d267de777e2597552f785174ad0373'>diff</a>)</td></tr><tr><th>parent</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/net/sched/sch_codel.c?h=nds-private-remove&amp;id=701dc207bf551d9fe6defa36e84a911e880398c3'>701dc207bf551d9fe6defa36e84a911e880398c3</a> (<a href='/cgit.cgi/linux/net-next.git/diff/net/sched/sch_codel.c?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79&amp;id2=701dc207bf551d9fe6defa36e84a911e880398c3'>diff</a>)</td></tr></table>
<div class='commit-subject'>Merge branch 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux</div><div class='commit-msg'>Pull i2c fixes from Wolfram Sang:
 "Bugfixes for I2C. Mostly core this time which is a bit unusual but
  nothing really scary in there"

* 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux:
  i2c: piix4: Avoid race conditions with IMC
  i2c: fix spelling mistake: "insufficent" -&gt; "insufficient"
  i2c: print correct device invalid address
  i2c: do not enable fall back to Host Notify by default
  i2c: fix kernel memory disclosure in dev interface
</div><div class='diffstat-header'><a href='/cgit.cgi/linux/net-next.git/diff/?h=nds-private-remove&amp;id=aa2797b30c322531981f24833b082446072d3c79'>Diffstat</a> (limited to 'net/sched/sch_codel.c')</div><table summary='diffstat' class='diffstat'>