/// Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element /// //# This makes an effort to find cases where the argument to sizeof is wrong //# in memory allocation functions by checking the type of the allocated memory //# when it is a double pointer and ensuring the sizeof argument takes a pointer //# to the the memory being allocated. There are false positives in cases the //# sizeof argument is not used in constructing the return value. The result //# may need some reformatting. // // Confidence: Moderate // Copyright: (C) 2014 Himangi Saraogi. GPLv2. // Comments: // Options: virtual patch virtual context virtual org virtual report //---------------------------------------------------------- // For context mode //---------------------------------------------------------- @depends on context disable sizeof_type_expr@ type T; T **x; @@ x = <+...sizeof( * T )...+> //---------------------------------------------------------- // For patch mode //---------------------------------------------------------- @depends on patch disable sizeof_type_expr@ type T; T **x; @@ x = <+...sizeof( - T + *x )...+> //---------------------------------------------------------- // For org and report mode //---------------------------------------------------------- @r depends on (org || report) disable sizeof_type_expr@ type T; T **x; position p; @@ x = <+...sizeof( T@p )...+> @script:python depends on org@ p << r.p; @@ coccilib.org.print_todo(p[0], "WARNING sizeof argument should be pointer type, not structure type") @script:python depends on report@ p << r.p; @@ msg="WARNING: Use correct pointer type argument for sizeof" coccilib.report.print_report(p[0], msg) ogtreecommitdiff
path: root/net/sunrpc/sysctl.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2017-01-30 11:26:38 +0100
committerJiri Kosina <jkosina@suse.cz>2017-01-31 12:59:32 +0100
commit7a7b5df84b6b4e5d599c7289526eed96541a0654 (patch)
treecf7514c7ddf4410fe37ca9099a2785e1cf08fa7d /net/sunrpc/sysctl.c
parent877a021e08ccb6434718c0cc781fdf943c884cc0 (diff)
HID: cp2112: fix sleep-while-atomic
A recent commit fixing DMA-buffers on stack added a shared transfer buffer protected by a spinlock. This is broken as the USB HID request callbacks can sleep. Fix this up by replacing the spinlock with a mutex. Fixes: 1ffb3c40ffb5 ("HID: cp2112: make transfer buffers DMA capable") Cc: stable <stable@vger.kernel.org> # 4.9 Signed-off-by: Johan Hovold <johan@kernel.org> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'net/sunrpc/sysctl.c')