/// Use BUG_ON instead of a if condition followed by BUG.
///
//# This makes an effort to find cases where BUG() follows an if
//# condition on an expression and replaces the if condition and BUG()
//# with a BUG_ON having the conditional expression of the if statement
//# as argument.
//
// Confidence: High
// Copyright: (C) 2014 Himangi Saraogi.  GPLv2.
// Comments:
// Options: --no-includes --include-headers

virtual patch
virtual context
virtual org
virtual report

//----------------------------------------------------------
//  For context mode
//----------------------------------------------------------

@depends on context@
expression e;
@@

*if (e) BUG();

//----------------------------------------------------------
//  For patch mode
//----------------------------------------------------------

@depends on patch@
expression e;
@@

-if (e) BUG();
+BUG_ON(e);

//----------------------------------------------------------
//  For org and report mode
//----------------------------------------------------------

@r depends on (org || report)@
expression e;
position p;
@@

 if (e) BUG@p ();

@script:python depends on org@
p << r.p;
@@

coccilib.org.print_todo(p[0], "WARNING use BUG_ON")

@script:python depends on report@
p << r.p;
@@

msg="WARNING: Use BUG_ON instead of if condition followed by BUG.\nPlease make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)"
coccilib.report.print_report(p[0], msg)

ux/net-next.git/'>summary</a><a href='/cgit.cgi/linux/net-next.git/refs/?id=dd8427a78ffccbacf166a2d5d5eae55b586e1afe'>refs</a><a class='active' href='/cgit.cgi/linux/net-next.git/log/include/sound/hda_hwdep.h'>log</a><a href='/cgit.cgi/linux/net-next.git/tree/include/sound/hda_hwdep.h?id=dd8427a78ffccbacf166a2d5d5eae55b586e1afe'>tree</a><a href='/cgit.cgi/linux/net-next.git/commit/include/sound/hda_hwdep.h?id=dd8427a78ffccbacf166a2d5d5eae55b586e1afe'>commit</a><a href='/cgit.cgi/linux/net-next.git/diff/include/sound/hda_hwdep.h?id=dd8427a78ffccbacf166a2d5d5eae55b586e1afe'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/include/sound/hda_hwdep.h'>
<input type='hidden' name='id' value='dd8427a78ffccbacf166a2d5d5eae55b586e1afe'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit.cgi/linux/net-next.git/log/?id=dd8427a78ffccbacf166a2d5d5eae55b586e1afe'>root</a>/<a href='/cgit.cgi/linux/net-next.git/log/include?id=dd8427a78ffccbacf166a2d5d5eae55b586e1afe'>include</a>/<a href='/cgit.cgi/linux/net-next.git/log/include/sound?id=dd8427a78ffccbacf166a2d5d5eae55b586e1afe'>sound</a>/<a href='/cgit.cgi/linux/net-next.git/log/include/sound/hda_hwdep.h?id=dd8427a78ffccbacf166a2d5d5eae55b586e1afe'>hda_hwdep.h</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/cgit.cgi/linux/net-next.git/log/include/sound/hda_hwdep.h?id=dd8427a78ffccbacf166a2d5d5eae55b586e1afe&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th><th class='left'>Files</th><th class='left'>Lines</th></tr>