/// Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") /// threaded IRQs without a primary handler need to be requested with /// IRQF_ONESHOT, otherwise the request will fail. /// /// So pass the IRQF_ONESHOT flag in this case. /// // // Confidence: Moderate // Comments: // Options: --no-includes virtual patch virtual context virtual org virtual report @r1@ expression dev, irq, thread_fn; position p; @@ ( request_threaded_irq@p(irq, NULL, thread_fn, ( IRQF_ONESHOT | ... | IRQF_ONESHOT ) , ...) | devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, ( IRQF_ONESHOT | ... | IRQF_ONESHOT ) , ...) ) @r2@ expression dev, irq, thread_fn, flags, e; position p != r1.p; @@ ( flags = IRQF_ONESHOT | ... | flags |= IRQF_ONESHOT | ... ) ... when != flags = e ( request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); | devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); ) @depends on patch@ expression dev, irq, thread_fn, flags; position p != {r1.p,r2.p}; @@ ( request_threaded_irq@p(irq, NULL, thread_fn, ( -0 +IRQF_ONESHOT | -flags +flags | IRQF_ONESHOT ) , ...) | devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, ( -0 +IRQF_ONESHOT | -flags +flags | IRQF_ONESHOT ) , ...) ) @depends on context@ expression dev, irq; position p != {r1.p,r2.p}; @@ ( *request_threaded_irq@p(irq, NULL, ...) | *devm_request_threaded_irq@p(dev, irq, NULL, ...) ) @match depends on report || org@ expression dev, irq; position p != {r1.p,r2.p}; @@ ( request_threaded_irq@p(irq, NULL, ...) | devm_request_threaded_irq@p(dev, irq, NULL, ...) ) @script:python depends on org@ p << match.p; @@ msg = "ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT" coccilib.org.print_todo(p[0],msg) @script:python depends on report@ p << match.p; @@ msg = "ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT" coccilib.report.print_report(p[0],msg) next.git/diff/?id=20ab6677716c7bbdcfd1cdb9aef296a0b3101f73'>diff
diff options
context:
space:
mode:
authorBorislav Petkov <bp@suse.de>2016-11-26 15:27:06 +0100
committerIngo Molnar <mingo@kernel.org>2016-11-28 07:46:03 +0100
commit20ab6677716c7bbdcfd1cdb9aef296a0b3101f73 (patch)
tree2de08baa01744c905a9a007c81c31ad5f4c6ae7e
parentc4597fd756836a5fb7900f2091797ab564390ad0 (diff)
x86/platform/olpc: Fix resume handler build warning
Fix: arch/x86/platform/olpc/olpc-xo15-sci.c:199:12: warning: ‘xo15_sci_resume’ defined but not used [-Wunused-function] static int xo15_sci_resume(struct device *dev) ^ which I see in randconfig builds here. Signed-off-by: Borislav Petkov <bp@suse.de> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/20161126142706.13602-1-bp@alien8.de Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat
rg> Cc: Sebastian Siewior <bigeasy@linutronix.de> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: <stable@vger.kernel.org> Link: http://lkml.kernel.org/r/20161130210030.431379999@linutronix.de Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat