/// Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") /// threaded IRQs without a primary handler need to be requested with /// IRQF_ONESHOT, otherwise the request will fail. /// /// So pass the IRQF_ONESHOT flag in this case. /// // // Confidence: Moderate // Comments: // Options: --no-includes virtual patch virtual context virtual org virtual report @r1@ expression dev, irq, thread_fn; position p; @@ ( request_threaded_irq@p(irq, NULL, thread_fn, ( IRQF_ONESHOT | ... | IRQF_ONESHOT ) , ...) | devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, ( IRQF_ONESHOT | ... | IRQF_ONESHOT ) , ...) ) @r2@ expression dev, irq, thread_fn, flags, e; position p != r1.p; @@ ( flags = IRQF_ONESHOT | ... | flags |= IRQF_ONESHOT | ... ) ... when != flags = e ( request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); | devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); ) @depends on patch@ expression dev, irq, thread_fn, flags; position p != {r1.p,r2.p}; @@ ( request_threaded_irq@p(irq, NULL, thread_fn, ( -0 +IRQF_ONESHOT | -flags +flags | IRQF_ONESHOT ) , ...) | devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, ( -0 +IRQF_ONESHOT | -flags +flags | IRQF_ONESHOT ) , ...) ) @depends on context@ expression dev, irq; position p != {r1.p,r2.p}; @@ ( *request_threaded_irq@p(irq, NULL, ...) | *devm_request_threaded_irq@p(dev, irq, NULL, ...) ) @match depends on report || org@ expression dev, irq; position p != {r1.p,r2.p}; @@ ( request_threaded_irq@p(irq, NULL, ...) | devm_request_threaded_irq@p(dev, irq, NULL, ...) ) @script:python depends on org@ p << match.p; @@ msg = "ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT" coccilib.org.print_todo(p[0],msg) @script:python depends on report@ p << match.p; @@ msg = "ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT" coccilib.report.print_report(p[0],msg) next.git/tree/sound/pci/asihpi/hpios.c?h=nds-private-remove&id=b272f732f888d4cf43c943a40c9aaa836f9b7431'>treecommitdiff
path: root/sound/pci/asihpi/hpios.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2016-12-25 14:05:56 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2016-12-25 14:05:56 -0800
commitb272f732f888d4cf43c943a40c9aaa836f9b7431 (patch)
treeda9cac6b9d12b83592c16d3503c0e3f2f00f146f /sound/pci/asihpi/hpios.c
parent10bbe7599e2755d3f3e100103967788b8b5a4bce (diff)
parent008b69e4d52f2cbee3ed0d0502edd78155000b1a (diff)
Merge branch 'smp-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull SMP hotplug notifier removal from Thomas Gleixner: "This is the final cleanup of the hotplug notifier infrastructure. The series has been reintgrated in the last two days because there came a new driver using the old infrastructure via the SCSI tree. Summary: - convert the last leftover drivers utilizing notifiers - fixup for a completely broken hotplug user - prevent setup of already used states - removal of the notifiers - treewide cleanup of hotplug state names - consolidation of state space There is a sphinx based documentation pending, but that needs review from the documentation folks" * 'smp-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: irqchip/armada-xp: Consolidate hotplug state space irqchip/gic: Consolidate hotplug state space coresight/etm3/4x: Consolidate hotplug state space cpu/hotplug: Cleanup state names cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions staging/lustre/libcfs: Convert to hotplug state machine scsi/bnx2i: Convert to hotplug state machine scsi/bnx2fc: Convert to hotplug state machine cpu/hotplug: Prevent overwriting of callbacks x86/msr: Remove bogus cleanup from the error path bus: arm-ccn: Prevent hotplug callback leak perf/x86/intel/cstate: Prevent hotplug callback leak ARM/imx/mmcd: Fix broken cpu hotplug handling scsi: qedi: Convert to hotplug state machine
Diffstat (limited to 'sound/pci/asihpi/hpios.c')