/// Use WARN(1,...) rather than printk followed by WARN_ON(1) /// // Confidence: High // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2. // Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. GPLv2. // URL: http://coccinelle.lip6.fr/ // Comments: // Options: --no-includes --include-headers virtual patch virtual context virtual org virtual report @bad1@ position p; @@ printk(...); printk@p(...); WARN_ON(1); @r1 depends on context || report || org@ position p != bad1.p; @@ printk@p(...); *WARN_ON(1); @script:python depends on org@ p << r1.p; @@ cocci.print_main("printk + WARN_ON can be just WARN",p) @script:python depends on report@ p << r1.p; @@ msg = "SUGGESTION: printk + WARN_ON can be just WARN" coccilib.report.print_report(p[0],msg) @ok1 depends on patch@ expression list es; position p != bad1.p; @@ -printk@p( +WARN(1, es); -WARN_ON(1); @depends on patch@ expression list ok1.es; @@ if (...) - { WARN(1,es); - } // -------------------------------------------------------------------- @bad2@ position p; @@ printk(...); printk@p(...); WARN_ON_ONCE(1); @r2 depends on context || report || org@ position p != bad1.p; @@ printk@p(...); *WARN_ON_ONCE(1); @script:python depends on org@ p << r2.p; @@ cocci.print_main("printk + WARN_ON_ONCE can be just WARN_ONCE",p) @script:python depends on report@ p << r2.p; @@ msg = "SUGGESTION: printk + WARN_ON_ONCE can be just WARN_ONCE" coccilib.report.print_report(p[0],msg) @ok2 depends on patch@ expression list es; position p != bad2.p; @@ -printk@p( +WARN_ONCE(1, es); -WARN_ON_ONCE(1); @depends on patch@ expression list ok2.es; @@ if (...) - { WARN_ONCE(1,es); - } 679d8864421ec'>refslogtreecommitdiff
path: root/fs/befs/btree.c
diff options
context:
space:
mode:
authorHelge Deller <deller@gmx.de>2017-01-28 11:52:02 +0100
committerHelge Deller <deller@gmx.de>2017-01-28 21:54:23 +0100
commit2ad5d52d42810bed95100a3d912679d8864421ec (patch)
tree7f93e2f906b1c86f5b76c0f4c0978d41a8a29861 /fs/befs/btree.c
parent83b5d1e3d3013dbf90645a5d07179d018c8243fa (diff)
parisc: Don't use BITS_PER_LONG in userspace-exported swab.h header
In swab.h the "#if BITS_PER_LONG > 32" breaks compiling userspace programs if BITS_PER_LONG is #defined by userspace with the sizeof() compiler builtin. Solve this problem by using __BITS_PER_LONG instead. Since we now #include asm/bitsperlong.h avoid further potential userspace pollution by moving the #define of SHIFT_PER_LONG to bitops.h which is not exported to userspace. This patch unbreaks compiling qemu on hppa/parisc. Signed-off-by: Helge Deller <deller@gmx.de> Cc: <stable@vger.kernel.org>
Diffstat (limited to 'fs/befs/btree.c')