/// Compare pointer-typed values to NULL rather than 0 /// //# This makes an effort to choose between !x and x == NULL. !x is used //# if it has previously been used with the function used to initialize x. //# This relies on type information. More type information can be obtained //# using the option -all_includes and the option -I to specify an //# include path. // // Confidence: High // Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. GPLv2. // Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. GPLv2. // URL: http://coccinelle.lip6.fr/ // Comments: Requires Coccinelle version 1.0.0-rc20 or later // Options: virtual patch virtual context virtual org virtual report @initialize:ocaml@ @@ let negtable = Hashtbl.create 101 @depends on patch@ expression *E; identifier f; @@ ( (E = f(...)) == - 0 + NULL | (E = f(...)) != - 0 + NULL | - 0 + NULL == (E = f(...)) | - 0 + NULL != (E = f(...)) ) @t1 depends on !patch@ expression *E; identifier f; position p; @@ ( (E = f(...)) == * 0@p | (E = f(...)) != * 0@p | * 0@p == (E = f(...)) | * 0@p != (E = f(...)) ) @script:python depends on org@ p << t1.p; @@ coccilib.org.print_todo(p[0], "WARNING comparing pointer to 0") @script:python depends on report@ p << t1.p; @@ coccilib.report.print_report(p[0], "WARNING comparing pointer to 0") // Tests of returned values @s@ identifier f; expression E,E1; @@ E = f(...) ... when != E = E1 !E @script:ocaml depends on s@ f << s.f; @@ try let _ = Hashtbl.find negtable f in () with Not_found -> Hashtbl.add negtable f () @ r disable is_zero,isnt_zero exists @ expression *E; identifier f; @@ E = f(...) ... (E == 0 |E != 0 |0 == E |0 != E ) @script:ocaml@ f << r.f; @@ try let _ = Hashtbl.find negtable f in () with Not_found -> include_match false // This rule may lead to inconsistent path problems, if E is defined in two // places @ depends on patch disable is_zero,isnt_zero @ expression *E; expression E1; identifier r.f; @@ E = f(...) <... ( - E == 0 + !E | - E != 0 + E | - 0 == E + !E | - 0 != E + E ) ...> ?E = E1 @t2 depends on !patch disable is_zero,isnt_zero @ expression *E; expression E1; identifier r.f; position p1; position p2; @@ E = f(...) <... ( * E == 0@p1 | * E != 0@p2 | * 0@p1 == E | * 0@p1 != E ) ...> ?E = E1 @script:python depends on org@ p << t2.p1; @@ coccilib.org.print_todo(p[0], "WARNING comparing pointer to 0, suggest !E") @script:python depends on org@ p << t2.p2; @@ coccilib.org.print_todo(p[0], "WARNING comparing pointer to 0") @script:python depends on report@ p << t2.p1; @@ coccilib.report.print_report(p[0], "WARNING comparing pointer to 0, suggest !E") @script:python depends on report@ p << t2.p2; @@ coccilib.report.print_report(p[0], "WARNING comparing pointer to 0") @ depends on patch disable is_zero,isnt_zero @ expression *E; @@ ( E == - 0 + NULL | E != - 0 + NULL | - 0 + NULL == E | - 0 + NULL != E ) @ t3 depends on !patch disable is_zero,isnt_zero @ expression *E; position p; @@ ( * E == 0@p | * E != 0@p | * 0@p == E | * 0@p != E ) @script:python depends on org@ p << t3.p; @@ coccilib.org.print_todo(p[0], "WARNING comparing pointer to 0") @script:python depends on report@ p << t3.p; @@ coccilib.report.print_report(p[0], "WARNING comparing pointer to 0") ec2b32650f4d30dd688&showmsg=1'>Expand)AuthorFilesLines comp.c
diff options
context:
space:
mode:
authorArd Biesheuvel <ard.biesheuvel@linaro.org>2017-02-01 17:45:02 +0000
committerIngo Molnar <mingo@kernel.org>2017-02-01 21:17:49 +0100
commitc8f325a59cfc718d13a50fbc746ed9b415c25e92 (patch)
treed53fbdac9d0781e39a13b2ac6b2bd258cf3b4140 /net/xfrm/xfrm_ipcomp.c
parentbf29bddf0417a4783da3b24e8c9e017ac649326f (diff)
efi/fdt: Avoid FDT manipulation after ExitBootServices()
Some AArch64 UEFI implementations disable the MMU in ExitBootServices(), after which unaligned accesses to RAM are no longer supported. Commit: abfb7b686a3e ("efi/libstub/arm*: Pass latest memory map to the kernel") fixed an issue in the memory map handling of the stub FDT code, but inadvertently created an issue with such firmware, by moving some of the FDT manipulation to after the invocation of ExitBootServices(). Given that the stub's libfdt implementation uses the ordinary, accelerated string functions, which rely on hardware handling of unaligned accesses, manipulating the FDT with the MMU off may result in alignment faults. So fix the situation by moving the update_fdt_memmap() call into the callback function invoked by efi_exit_boot_services() right before it calls the ExitBootServices() UEFI service (which is arguably a better place for it anyway) Note that disabling the MMU in ExitBootServices() is not compliant with the UEFI spec, and carries great risk due to the fact that switching from cached to uncached memory accesses halfway through compiler generated code (i.e., involving a stack) can never be done in a way that is architecturally safe. Fixes: abfb7b686a3e ("efi/libstub/arm*: Pass latest memory map to the kernel") Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Tested-by: Riku Voipio <riku.voipio@linaro.org> Cc: <stable@vger.kernel.org> Cc: mark.rutland@arm.com Cc: linux-efi@vger.kernel.org Cc: matt@codeblueprint.co.uk Cc: leif.lindholm@linaro.org Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/1485971102-23330-2-git-send-email-ard.biesheuvel@linaro.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'net/xfrm/xfrm_ipcomp.c')