/// This semantic patch looks for kmalloc etc that are not followed by a /// NULL check. It only gives a report in the case where there is some /// error handling code later in the function, which may be helpful /// in determining what the error handling code for the call to kmalloc etc /// should be. /// // Confidence: High // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2. // Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2. // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2. // URL: http://coccinelle.lip6.fr/ // Comments: // Options: --no-includes --include-headers virtual context virtual org virtual report @withtest@ expression x; position p; identifier f,fld; @@ x@p = f(...); ... when != x->fld \(x == NULL \| x != NULL\) @fixed depends on context && !org && !report@ expression x,x1; position p1 != withtest.p; statement S; position any withtest.p; identifier f; @@ *x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... *x1@p = f(...); if (!x1) S // ------------------------------------------------------------------------ @rfixed depends on (org || report) && !context exists@ expression x,x1; position p1 != withtest.p; position p2; statement S; position any withtest.p; identifier f; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... x1@p = f@p2(...); if (!x1) S @script:python depends on org@ p1 << rfixed.p1; p2 << rfixed.p2; @@ cocci.print_main("alloc call",p1) cocci.print_secs("possible model",p2) @script:python depends on report@ p1 << rfixed.p1; p2 << rfixed.p2; @@ msg = "alloc with no test, possible model on line %s" % (p2[0].line) coccilib.report.print_report(p1[0],msg) t/refs/?id=0becc0ae5b42828785b589f686725ff5bc3b9b25'>refslogtreecommitdiff
path: root/security/selinux/include/classmap.h
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2017-01-31 09:37:34 +0100
committerThomas Gleixner <tglx@linutronix.de>2017-01-31 21:47:58 +0100
commit0becc0ae5b42828785b589f686725ff5bc3b9b25 (patch)
treebe6d0e1f37c38ed0a7dd5da2d4b1e93f0fb43101 /security/selinux/include/classmap.h
parent24c2503255d35c269b67162c397a1a1c1e02f6ce (diff)
x86/mce: Make timer handling more robust
Erik reported that on a preproduction hardware a CMCI storm triggers the BUG_ON in add_timer_on(). The reason is that the per CPU MCE timer is started by the CMCI logic before the MCE CPU hotplug callback starts the timer with add_timer_on(). So the timer is already queued which triggers the BUG. Using add_timer_on() is pretty pointless in this code because the timer is strictlty per CPU, initialized as pinned and all operations which arm the timer happen on the CPU to which the timer belongs. Simplify the whole machinery by using mod_timer() instead of add_timer_on() which avoids the problem because mod_timer() can handle already queued timers. Use __start_timer() everywhere so the earliest armed expiry time is preserved. Reported-by: Erik Veijola <erik.veijola@intel.com> Tested-by: Borislav Petkov <bp@alien8.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Borislav Petkov <bp@alien8.de> Cc: Tony Luck <tony.luck@intel.com> Link: http://lkml.kernel.org/r/alpine.DEB.2.20.1701310936080.3457@nanos Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'security/selinux/include/classmap.h')