/// This semantic patch looks for kmalloc etc that are not followed by a /// NULL check. It only gives a report in the case where there is some /// error handling code later in the function, which may be helpful /// in determining what the error handling code for the call to kmalloc etc /// should be. /// // Confidence: High // Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2. // Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2. // Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2. // URL: http://coccinelle.lip6.fr/ // Comments: // Options: --no-includes --include-headers virtual context virtual org virtual report @withtest@ expression x; position p; identifier f,fld; @@ x@p = f(...); ... when != x->fld \(x == NULL \| x != NULL\) @fixed depends on context && !org && !report@ expression x,x1; position p1 != withtest.p; statement S; position any withtest.p; identifier f; @@ *x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... *x1@p = f(...); if (!x1) S // ------------------------------------------------------------------------ @rfixed depends on (org || report) && !context exists@ expression x,x1; position p1 != withtest.p; position p2; statement S; position any withtest.p; identifier f; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... x1@p = f@p2(...); if (!x1) S @script:python depends on org@ p1 << rfixed.p1; p2 << rfixed.p2; @@ cocci.print_main("alloc call",p1) cocci.print_secs("possible model",p2) @script:python depends on report@ p1 << rfixed.p1; p2 << rfixed.p2; @@ msg = "alloc with no test, possible model on line %s" % (p2[0].line) coccilib.report.print_report(p1[0],msg) gi/linux/net-next.git/refs/?id=030305d69fc6963c16003f50d7e8d74b02d0a143'>refslogtreecommitdiff
path: root/net/ceph/ceph_common.c
diff options
context:
space:
mode:
authorBjorn Helgaas <bhelgaas@google.com>2017-01-27 15:00:45 -0600
committerBjorn Helgaas <bhelgaas@google.com>2017-01-27 15:00:45 -0600
commit030305d69fc6963c16003f50d7e8d74b02d0a143 (patch)
tree363a4e34d199178769b7e7eeb26ea2620a55847b /net/ceph/ceph_common.c
parent4d191b1b63c209e37bf27938ef365244d3c41084 (diff)
PCI/ASPM: Handle PCI-to-PCIe bridges as roots of PCIe hierarchies
In a struct pcie_link_state, link->root points to the pcie_link_state of the root of the PCIe hierarchy. For the topmost link, this points to itself (link->root = link). For others, we copy the pointer from the parent (link->root = link->parent->root). Previously we recognized that Root Ports originated PCIe hierarchies, but we treated PCI/PCI-X to PCIe Bridges as being in the middle of the hierarchy, and when we tried to copy the pointer from link->parent->root, there was no parent, and we dereferenced a NULL pointer: BUG: unable to handle kernel NULL pointer dereference at 0000000000000090 IP: [<ffffffff9e424350>] pcie_aspm_init_link_state+0x170/0x820 Recognize that PCI/PCI-X to PCIe Bridges originate PCIe hierarchies just like Root Ports do, so link->root for these devices should also point to itself. Fixes: 51ebfc92b72b ("PCI: Enumerate switches below PCI-to-PCIe bridges") Link: https://bugzilla.kernel.org/show_bug.cgi?id=193411 Link: https://bugzilla.opensuse.org/show_bug.cgi?id=1022181 Tested-by: lists@ssl-mail.com Tested-by: Jayachandran C. <jnair@caviumnetworks.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> CC: stable@vger.kernel.org # v4.2+
Diffstat (limited to 'net/ceph/ceph_common.c')